Regression in fs.readFile

Version

v23.1.0

Platform

Linux akait-notebook 6.8.0-47-generic #47-Ubuntu SMP PREEMPT_DYNAMIC Fri Sep 27 21:40:26 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Subsystem

No response

What steps will reproduce the bug?

const fs = require("fs");

fs.readFile("/", err => {
	console.log(err);
});

fs.readFile("/", err => {
	console.log(err);
});

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior? Why is that the expected behavior?

Like in Node.js@22, each callback should be run with err and code should be EISDIR

What do you see instead?

The call happens only once for the first call and the callbacks are not called instead an error is thrown like for sync function

Additional information

Ref: webpack/webpack#18891

The call happens only once for the first call and the callbacks are not called instead an error is thrown like for sync function

AFAICT this is not the case. While I'm able to reproduce the issue, no call appears to use the callback, and an error is thrown.

This is because getValidatedPath does not return the error to the callback, but instead throws it.

@redyetidev In our case, we often call this function with /, the second call does not even throw an error, so try/catch doesn't help in this case

I'll bisect.

Same in macos

The regression seems to be introduced by #54160

Maybe here? https://github.com/nodejs/node/pull/54160/files#diff-5cd422a9a64bc2c1275d70ba5dcafbc5ea55274432fffc5e4159126007dc4894R735-R741

The regression is reverted, I'm closing this issue.

@juanarbol

@juanarbol When will be the patch released?

Navigation Menu

Repository navigation

Regression in `fs.readFile` #55609

Version

Platform

Subsystem

What steps will reproduce the bug?

How often does it reproduce? Is there a required condition?

What is the expected behavior? Why is that the expected behavior?

What do you see instead?

Additional information

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Regression in fs.readFile #55609

Description

Version

Platform

Subsystem

What steps will reproduce the bug?

How often does it reproduce? Is there a required condition?

What is the expected behavior? Why is that the expected behavior?

What do you see instead?

Additional information

Activity

avivkeller commented on Oct 30, 2024

alexander-akait commented on Oct 30, 2024

juanarbol commented on Oct 31, 2024

juanarbol commented on Oct 31, 2024

juanarbol commented on Oct 31, 2024

juanarbol commented on Nov 3, 2024

snitin315 commented on Nov 3, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Regression in `fs.readFile` #55609