Skip to content

Modules: node:module API > Customization Hooks > Examples > Import from HTTPS #55091

Closed
#55111
Closed
Modules: node:module API > Customization Hooks > Examples > Import from HTTPS#55091
#55111
Labels
docIssues and PRs related to Node.js documentation.good first issueIssues that are suitable for first-time contributors.moduleIssues and PRs related to the module subsystem.

Description

@77it
77it
opened on Sep 23, 2024

Affected URL(s)

https://nodejs.org/dist/latest/docs/api/module.html#import-from-https

Description of the problem

in the page is present a text pointing to an header no more live

In current Node.js, specifiers starting with https:// are experimental (see [HTTPS and HTTP imports][]).

in the previous documentation version the link pointed to https://nodejs.org/docs/latest-v21.x/api/esm.html#https-and-http-imports that is now removed

Activity

  1. 77it
    added
    docIssues and PRs related to Node.js documentation.
    on Sep 23, 2024

  2. 77it commented on Sep 23, 2024

    @77it
    77it
    on Sep 23, 2024
    Author

    Also, after the removal of --experimental-network-imports with #53822, I wanted to ask if importing modules from HTTPS with hooks is a feature that can be relied on in the future, or can be subject to removal as happened with --experimental-network-imports.

  3. avivkeller commented on Sep 23, 2024

    @avivkeller
    avivkeller
    on Sep 23, 2024
    Member

    Looks like an oversight, feel free to submit a PR removing it if you'd like (You'll get a shiny contributor badge 👀 ). The entire feature has been removed, it just looks like the docs werent updated.

  4. avivkeller
    added
    loadersIssues and PRs related to ES module loaders.
    moduleIssues and PRs related to the module subsystem.
    good first issueIssues that are suitable for first-time contributors.
    and removed
    loadersIssues and PRs related to ES module loaders.
    on Sep 23, 2024

  5. geeksilva97 commented on Sep 24, 2024

    @geeksilva97
    geeksilva97
    on Sep 24, 2024
    Contributor

    @77it let me know if I can work on this PR.

  6. geeksilva97 commented on Sep 24, 2024

    @geeksilva97
    geeksilva97
    on Sep 24, 2024
    Contributor

    @redyetidev should the whole section Import from HTTPS be removed?

  7. avivkeller commented on Sep 24, 2024

    @avivkeller
    avivkeller
    on Sep 24, 2024
    Member

    No, just that line. The section is showing an example of how to setup an HTTP(S) import.

  8. 77it commented on Sep 25, 2024

    @77it
    77it
    on Sep 25, 2024
    Author

    @77it let me know if I can work on this PR.

    Sure, fine for me

    The whole section must be preserved, only the obsolete line have to be removed

  9. nodejs-github-bot
    closed this as completedin #55111on Sep 28, 2024
  10. nodejs-github-bot
    added a commit that references this issue on Sep 28, 2024

    doc: remove outdated https import reference

    6d1cd50
  11. targos
    added 2 commits that reference this issue on Oct 4, 2024

    doc: remove outdated https import reference

    1f7566d

    doc: remove outdated https import reference

    bb34990
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    docIssues and PRs related to Node.js documentation.good first issueIssues that are suitable for first-time contributors.moduleIssues and PRs related to the module subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions