parallel.test-macos-app-sandbox is flaky

Test

parallel.test-macos-app-sandbox

Platform

macOS x64

Console output

---
duration_ms: 11506.516
exitcode: 1
severity: fail
stack: |-
  node:assert:126
    throw new AssertionError(obj);
    ^

  AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

  1 !== 0

      at Object.<anonymous> (/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx11-x64/test/parallel/test-macos-app-sandbox.js:47:8)
      at Module._compile (node:internal/modules/cjs/loader:1546:14)
      at Module._extensions..js (node:internal/modules/cjs/loader:1691:10)
      at Module.load (node:internal/modules/cjs/loader:1317:32)
      at Module._load (node:internal/modules/cjs/loader:1127:12)
      at TracingChannel.traceSync (node:diagnostics_channel:315:14)
      at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)
      at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:166:5)
      at node:internal/main/run_main_module:30:49 {
    generatedMessage: true,
    code: 'ERR_ASSERTION',
    actual: 1,
    expected: 0,
    operator: 'strictEqual'
  }

  Node.js v23.0.0-pre
...

Build links

https://ci.nodejs.org/job/node-test-commit-osx/61230/nodes=osx11-x64/testReport/junit/%28root%29/parallel/test_macos_app_sandbox/

Additional information

No response

Cannot reproduce locally on macOS

$ tools/test.py --repeat 9999 test/parallel/test-macos-app-sandbox.js -t 9 
[02:34|% 100|+ 9999|-   0]: Done                          

All tests passed.

It might be related to the disk space issues on macOS (nodejs/build#3887).

See #54802 (comment) for some thoughts -- the assertion failure is from spawning a child codesign process:

It's not impossible, but the test does a free disk space check:

node/test/parallel/test-macos-app-sandbox.js

Lines 20 to 22 in b77476d

if (!tmpdir.hasEnoughSpace(120 * 1024 * 1024)) {

common.skip('Available disk space < 120MB');

}

and also the copyfiles are not the lines failing (which would suggest the copies were successful?)

node/test/parallel/test-macos-app-sandbox.js

Lines 29 to 43 in b77476d

// Construct the app bundle and put the node executable in it:

// node_sandboxed.app/

// └── Contents

// ├── Info.plist

// ├── MacOS

// │ └── node

fs.mkdirSync(appBundlePath);

fs.mkdirSync(appBundleContentPath);

fs.mkdirSync(path.join(appBundleContentPath, 'MacOS'));

fs.copyFileSync(

fixtures.path('macos-app-sandbox', 'Info.plist'),

path.join(appBundleContentPath, 'Info.plist'));

fs.copyFileSync(

nodeBinary,

appExecutablePath);

The failing line 47 is spawning codesign but it's swallowing any messages from the process to indicate why it failed:

node/test/parallel/test-macos-app-sandbox.js

Lines 46 to 54 in b77476d

// Sign the app bundle with sandbox entitlements:

assert.strictEqual(

child_process.spawnSync('/usr/bin/codesign', [

'--entitlements', fixtures.path(

'macos-app-sandbox', 'node_sandboxed.entitlements'),

'--force', '-s', '-',

appBundlePath,

]).status,

0);

Maybe this could be using the utilities from common/child_process (to take advantage of #54622)?

test: remove test-macos-app-sandbox flaky designation

Navigation Menu

Repository navigation

`parallel.test-macos-app-sandbox` is flaky #54811

Test

Platform

Console output

Build links

Additional information

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (!tmpdir.hasEnoughSpace(120 * 1024 * 1024)) {
	common.skip('Available disk space < 120MB');
	}

	// Construct the app bundle and put the node executable in it:
	// node_sandboxed.app/
	// └── Contents
	// ├── Info.plist
	// ├── MacOS
	// │ └── node
	fs.mkdirSync(appBundlePath);
	fs.mkdirSync(appBundleContentPath);
	fs.mkdirSync(path.join(appBundleContentPath, 'MacOS'));
	fs.copyFileSync(
	fixtures.path('macos-app-sandbox', 'Info.plist'),
	path.join(appBundleContentPath, 'Info.plist'));
	fs.copyFileSync(
	nodeBinary,
	appExecutablePath);

	// Sign the app bundle with sandbox entitlements:
	assert.strictEqual(
	child_process.spawnSync('/usr/bin/codesign', [
	'--entitlements', fixtures.path(
	'macos-app-sandbox', 'node_sandboxed.entitlements'),
	'--force', '-s', '-',
	appBundlePath,
	]).status,
	0);

parallel.test-macos-app-sandbox is flaky #54811

Description

Test

Platform

Console output

Build links

Additional information

Activity

aduh95 commented on Sep 6, 2024

richardlau commented on Sep 6, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

`parallel.test-macos-app-sandbox` is flaky #54811