Function redefinition in vm.runInContext

Possible bug of iojs or perhaps v8?

    var vm = require('vm'), ctx = vm.createContext({});

    vm.runInContext('function test(){return 0}', ctx);
    vm.runInContext('function test(){return 1}', ctx);

    var result = vm.runInContext('test()', ctx);
    // returns 0 in io.js, but 1 in node.js

Tested under win7 x64 and linux.

Confirmed result difference, 0 in iojs and 1 in node (all current versions (0.10.33 & 0.11.15)

It seems that a Context is a proxy object in node.js, but a plain object in io.js

What version of node? Likely this is due to the switch to contextify internally.

This does seem bad, as the intention here is similar to

<script>
function test() { return 0; }
</script>

<script>
function test() { return 1; }
</script>

<script>
alert(test());
</script>

(which alerts 1).

I wonder if it is due to 3c5ea41

@domenic

@domenic not directly / not alone, that commit exists in 0.11.15, which also appears to have the bug.

@Fishrock123

@Fishrock123 right, I am wondering what the behavior was before that commit but after the contextify switch.

Possibly related: nodejs/node-v0.x-archive#9084

Still returning 0 on v2.1.0.
Could be interesting to test on next branch, maybe with #1773 ?

@domenic

@domenic is this fixed in next?

Haven't been able to test this with the new patches, but I didn't see any reason why the new patches would necessarily fix it. I still have a list of vm bugs to work on :)

Behavior still occurs in 3.0, marking as a bug!

Still returns 0 in v4.2.0.

repl: remove workaround for function redefinition

test: move test-vm-function-redefinition to parallel

repl: remove workaround for function redefinition

test: move test-vm-function-redefinition to parallel

Navigation Menu

Repository navigation

Function redefinition in vm.runInContext #548

72 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Function redefinition in vm.runInContext #548

Description

Activity

Fishrock123 commented on Jan 22, 2015

kyriosli commented on Jan 22, 2015

chrisdickinson commented on Jan 22, 2015

domenic commented on Jan 22, 2015

Fishrock123 commented on Jan 22, 2015

domenic commented on Jan 27, 2015

piscisaureus commented on Jan 29, 2015

targos commented on May 24, 2015

Fishrock123 commented on Jun 5, 2015

domenic commented on Jun 5, 2015

brendanashworth commented on Aug 14, 2015

Trott commented on Oct 13, 2015

72 remaining items

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions