Skip to content

test/mock_loader module exposed without node: prefix #54071

Description

@Renegade334

The builtin module test/mock_loader was added in v22.3.0. However, it wasn't added to schemelessBlockList, meaning it's currently importable as "test/mock_loader", and appears in module.builtinModules.

Could be as simple as adding the new module to the list, although I wonder if realm.js should implement some kind of matching behaviour so that if a module foo is in schemelessBlockList, then any foo/bar submodules are automatically excluded as well.

Activity

changed the title [-]`tests/mock_loader` module exposed without `node:` prefix[/-] [+]`test/mock_loader` module exposed without `node:` prefix[/+] on Jul 27, 2024

cjihrig commented on Jul 28, 2024

@cjihrig
Contributor

One thing to note is that the loader is not intended to be public at all. We need register() to support internals (it didn't the last time I tested it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions