Repository navigation
Test_runner: --experimental-test-coverage detects uncovered lines incorrectly. #53719
Description
Activity
Thanks for the report! Could you provide a minimally reproducible example? One without any external dependencies / repos?
RedYetiDev
I will try
Are you enabling source maps?
Reacted by Moshe AtlowAre you enabling source maps?
No, but how it should affects a test coverage? Tests running on already compiled and not minified code.
But affects in fact. I have tried to enable sourceMap in a tsconfig. In this case tests were passed successfully but coverage calculation failed with a message: Warning: Could not report code coverage. TypeError: Cannot read properties of undefined (reading 'line')
Hm, I tried running the tests and added some print statements. The
if (Object.keys(errors).length === 0)statement in question was never entered for me. Maybe I'm doing something wrong?Hm, I tried running the tests and added some print statements. The
if (Object.keys(errors).length === 0)statement in question was never entered for me. Maybe I'm doing something wrong?I read the tests very carefully. Yeah, it turns out that this check looks appropriate in the context of a single function. But from the outside this function is called in such a way that this condition will never be fulfilled. A kind of overkill. I apologize for the time spent. It seems that everything fine with the coverage calculation.
Version
20.15.0
Platform
Subsystem
No response
What steps will reproduce the bug?
git@github.com:muturgan/fastest-express-validator.gituncovered linescolunm of adist/index.cjsfileHow often does it reproduce? Is there a required condition?
It reproduces every time. No special conditions are needed.
What is the expected behavior? Why is that the expected behavior?
Report of a
dist/index.cjsfile is NOT contains 53-55 uncovered lines (which corresponds to adefaultRequestValidatorHandlersuccess branch). Because of I have acorrect user requesttest case which not produces a validation error.What do you see instead?
The coverage report of a
dist/index.cjsfile mark 53-55 lines as uncovered.Additional information
No response