c-ares update script broken by c-ares 1.30.0 #53407

Activity

1. marco-ippolito

   added

   toolsIssues and PRs related to the tools directory.Issues and PRs related to the tools directory.

   on Jun 10, 2024
2. richardlau commented on Jun 10, 2024

   

   richardlau

   on Jun 10, 2024

   Last edited by richardlau

   Member

   More actions

   The tag names have changed. They used to be of the form:

   • cares-1_29_0

   i.e. prefixed with cares- and the numerical parts of the version separated with _.
   For c-ares 1.30.0 the tag is v1.30.0. Assuming the tags now follow this format we could update the update script to drop the leading v (and the replacement of _ with . is no longer necessary) as a quick fix.

   The correct thing to do is probably to parse the assets out of https://api.github.com/repos/c-ares/c-ares/releases/latest instead of just the tag_name which would give the actual URLs without the update script having to make assumptions as to the format of the download URL (for example, the download URL contains the leading v for the tag).

   👍React with 👍1Reacted by Michaël Zasso
3. nodejs-github-bot

   closed this as completedin #53414on Jun 13, 2024
4. nodejs-github-bot

   added a commit that references this issue on Jun 13, 2024

   tools: fix c-ares update script

   ...

   c64a00a
5. targos

   added a commit that references this issue on Jun 20, 2024

   tools: fix c-ares update script

   ...

   fe85e05
6. eliphazbouye

   added a commit that references this issue on Jun 20, 2024

   tools: fix c-ares update script

   ...

   a30fef1