test pummel/test-stream2-basic.js failing since v4.2.0

Test seems to be failing since version 4.2.0, is it still a valid test case?

./node test/pummel/test-stream2-basic.js
# a most basic test
# pipe
# unpipe
# unpipe
# unpipe
# unpipe
# unpipe
# unpipe
# unpipe
# unpipe
# unpipe
# multipipe
# multi-unpipe
# multi-unpipe
# multi-unpipe
# multi-unpipe
# multi-unpipe
# multi-unpipe
# multi-unpipe
# multi-unpipe
# multi-unpipe
# back pressure respected
w1.emit("close")
w2 write [ 'two' ] 0
w3 write [ 'two' ] 1
w2 drain
w2 write [ 'three' ] 1

assert.js:89
  throw new assert.AssertionError({
  ^
AssertionError: 1 == 0
    at Readable.w2.write (node-js/test/pummel/test-stream2-basic.js:336:12)
    at Readable.ondata (_stream_readable.js:528:20)
    at emitOne (events.js:82:20)
    at Readable.emit (events.js:169:7)
    at Readable.read (_stream_readable.js:360:10)
    at flow (_stream_readable.js:743:26)
    at Readable.<anonymous> (_stream_readable.js:601:7)
    at emitNone (events.js:67:13)
    at Readable.emit (events.js:166:7)
    at null._onTimeout (node-js/test/pummel/test-stream2-basic.js:347:10)

That is one of four tests I'm aware of in test/pummel that are currently broken:

test-fs-watch-file
test-http-upload-timeout
test-keep-alive
test-stream2-basic

Is there a publicly visible CI system (like jenkins) available somewhere where to check the status of tests? Would be nice to know if test is expected to fail or is there something wrong with my own build ;)

I have fixed (on our own CI) test-fs-watch-file by adding call to common.refreshTmpDir and test-http-upload-timeout by increasing the socket timeout (our testing happens if fairly slow MIPS environment).

@tallskog

@tallskog The CI system is usually publicly available, but it is closed off at the moment for security reasons. You can follow #5194 to find out when it is resolved and the CI is made public again.

Access to CI would not help you in this case, however, because the pummel tests are not run on CI.

I don't know the history on that and therefore I don't know if that is likely to change or not if the four tests are fixed.

However, I would encourage you to submit a pull request for the fix to test-fs-watch-file as I and others are very interested in getting all the tests working again.

/cc @nodejs/testing

stream: Fix readableState.awaitDrain mechanism

Navigation Menu

Repository navigation

test pummel/test-stream2-basic.js failing since v4.2.0 #5257

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

test pummel/test-stream2-basic.js failing since v4.2.0 #5257

Description

Activity

Trott commented on Feb 16, 2016

tallskog commented on Feb 17, 2016

Trott commented on Feb 17, 2016

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions