You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the /test folder is full of thousands, seemingly random files.
What is the feature you are proposing to solve the problem?
I propose a reorganization of this folder so that:
(A) GitHub doesn't truncate the files to first 1000 when loading in the repo
(B) The files will be easier to find
what is a suggested alternative?
I don't think this is something that makes the codebase hard since you either add a new file, or edit a file that you already know the name of, and haven't heard anyone else complain about this. however I am willing to here (or just review a PR) with suggestions
That would make git log test/paralell/... harder. Also /test/<...>/<subsystem>/<test>.js isn't really too different from test-...-<subsystem>-test.js and in general the tests are named in the pattern test-<module>-<api>.js already. They are definitely not randomly named. For example if you want to run all the http tests you could just do tools/test.py "*/*http*". And as you add more folders than you'll need to differentiate the parallel ones and the sequential ones, which isn't as clear as just putting them in the parallel/sequential folder.
Activity
MoLow commentedon Apr 13, 2024
what is a suggested alternative?
I don't think this is something that makes the codebase hard since you either add a new file, or edit a file that you already know the name of, and haven't heard anyone else complain about this. however I am willing to here (or just review a PR) with suggestions
avivkeller commentedon Apr 13, 2024
I'd feel like organizing it to
/test/<...>/<subsystem>/<test>.jswould be easier. But that's not an easy task.joyeecheung commentedon Apr 13, 2024
That would make
git log test/paralell/...harder. Also/test/<...>/<subsystem>/<test>.jsisn't really too different fromtest-...-<subsystem>-test.jsand in general the tests are named in the patterntest-<module>-<api>.jsalready. They are definitely not randomly named. For example if you want to run all the http tests you could just dotools/test.py "*/*http*". And as you add more folders than you'll need to differentiate the parallel ones and the sequential ones, which isn't as clear as just putting them in theparallel/sequentialfolder.