Skip to content

Reorganize Node Tests #52502

Closed as not planned
Closed as not planned

Description

@avivkeller

What is the problem this feature will solve?

Currently, the /test folder is full of thousands, seemingly random files.

What is the feature you are proposing to solve the problem?

I propose a reorganization of this folder so that:
(A) GitHub doesn't truncate the files to first 1000 when loading in the repo
(B) The files will be easier to find

What alternatives have you considered?

No response

Activity

  1. MoLow commented on Apr 13, 2024

    @MoLow
    Member

    what is a suggested alternative?
    I don't think this is something that makes the codebase hard since you either add a new file, or edit a file that you already know the name of, and haven't heard anyone else complain about this. however I am willing to here (or just review a PR) with suggestions

  2. avivkeller commented on Apr 13, 2024

    @avivkeller
    MemberAuthor

    I'd feel like organizing it to /test/<...>/<subsystem>/<test>.js would be easier. But that's not an easy task.

  3. joyeecheung commented on Apr 13, 2024

    @joyeecheung
    Member

    That would make git log test/paralell/... harder. Also /test/<...>/<subsystem>/<test>.js isn't really too different from test-...-<subsystem>-test.js and in general the tests are named in the pattern test-<module>-<api>.js already. They are definitely not randomly named. For example if you want to run all the http tests you could just do tools/test.py "*/*http*". And as you add more folders than you'll need to differentiate the parallel ones and the sequential ones, which isn't as clear as just putting them in the parallel/sequential folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    feature requestIssues requesting new Node.js features.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions