Skip to content

aarch64 and arm64 inconsistencies #5175

Description

@jbergstroem

./configure currently sets host/target_arch as arm64 whereas Makefile will treat it as aarch64 (uname -s doesn't match anything). Suggesting we give Makefile a similar treatment?

/cc @nodejs/build

Activity

  1. added
    buildIssues and PRs related to Node.js builds or CI infrastructure.
    on Feb 10, 2016
  2. rvagg commented on Feb 10, 2016

    @rvagg
    Member

    I don't mind unifying it a little like we do for x86/ia32 (although even there we're not fully unified thanks mainly to gyp).

    @jbergstroem as an aside: both ARCH and DESTCPU are passed for the iojs+release Jenkins job which is why we need to have them explicitly set on the release machines, otherwise it comes out as ARCH="" DESTCPU="" and in Makefile that's read as those variables being set and not up for auto detection. xgene-3 missing both of these env vars lead to failure because Jenkins is configured to use them (which I prefer fwiw).

  3. jbergstroem commented on Feb 10, 2016

    @jbergstroem
    MemberAuthor

    @rvagg I would personally prefer using them only if set so we can fall back on defaults but don't have a strong opinion about it. Don't break what works (like I did last time), I guess.

  4. added
    armIssues and PRs related to the ARM architecture.
    on Feb 10, 2016
  5. added a commit that references this issue on Feb 15, 2016
  6. added a commit that references this issue on Feb 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    armIssues and PRs related to the ARM architecture.buildIssues and PRs related to Node.js builds or CI infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions