Skip to content

module.register is not chainable #50886

Description

@himself65

Version

v20.10.0

Platform

Darwin Alexs-MacBook-Pro.local 23.1.0 Darwin Kernel Version 23.1.0: Mon Oct 9 21:28:45 PDT 2023; root:xnu-10002.41.9~6/RELEASE_ARM64_T6020 arm64

Subsystem

module

What steps will reproduce the bug?

// register.js
export async function resolve (specifier, context, nextResolve) {
  // Take an `import` or `require` specifier and resolve it to a URL.
  console.log('context', context.conditions)
  return nextResolve(specifier,
    {
      ...context,
      conditions: [...context.conditions, 'react-server']
    },
    nextResolve)
}
// register2.js
export async function resolve (specifier, context, nextResolve) {
  // Take an `import` or `require` specifier and resolve it to a URL.
  console.log('context2', context.conditions)
  return nextResolve(specifier, context, nextResolve)
}
// main.js
import { register } from 'node:module'

register('./register.js', import.meta.url)
register('./register2.js', import.meta.url)

console.log('1')

import('./test.js')
// test.js
console.log(3)

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior? Why is that the expected behavior?

> node ./worker.js
1
context [ 'node', 'import', 'node-addons' ]
context2 [ 'node', 'import', 'node-addons', 'react-server' ]
context [ 'node', 'import', 'node-addons' ]
3

What do you see instead?

> node ./worker.js
1
context [ 'node', 'import', 'node-addons' ]
context2 [ 'node', 'import', 'node-addons' ]
context [ 'node', 'import', 'node-addons' ]
3

Additional information

No response

Activity

  1. added
    moduleIssues and PRs related to the module subsystem.
    on Nov 23, 2023
  2. himself65 commented on Nov 27, 2023

    @himself65
    MemberAuthor

    Oh I just realize that I ran it in the wrong order

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    moduleIssues and PRs related to the module subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions