Repository navigation
fs: utf8 fast paths don't accept all valid utf8 values #49888
Description
Activity
Seems there needs to be a call to normalizeEncoding
I don't think that would be needed, there's only 4 cases where that returns
utf8and it's with the values:utf8,utf-8,UTF8,UTF-8. It might be worth making a small util to check for those (not sure if the function call would add overhead or not).yeah, but you could also have mixed cases, like 'Utf-8' right?
Oh right as a final check. I don't think fast paths should have to worry about that for now at least as I doubt it's common and would add measurable overhead?
I once wrote for testing all permutations of uppercase/lowercase into a Map and it improved the performance of normalizeEncoding. This sounds like a use case for normalizeEncoding.
Reacted by Benjamin GruenbaumI marked this as good first issue since the handling should easy to unify.
@BridgeAR, @CanadaHonk Can I take this as a good first issue?
@BridgeAR , @CanadaHonk , if this issue is still open ,can I take this as a good first issue?
i think that it is special character if you file name are file_name emoji.txt are not valid . correct way your file name without any emoji are better way.
- added a commit that references this issue
on Mar 22, 2026 - added a commit that references this issue
on Jun 3, 2026 Hello everyone, I'm making an effort to start contributing to the project, and I would like to know if anyone knows if the current open PR's are already "on their way to merge" or if this issue still has space to be worked on.
#62304 and #60539 seem to be "accepted" by some members, but it also looks like there is a dependent issue that affects CI that needs to be merged before they do. cc @ChALkeR (Sorry for the mention, it seems like you are not tagged into this issue, but you are involved in one of the PR's, so it feels right to include you here)
I'm reading the contribution material and trying to get a feel of how the issues and contributions work, and I would appreciate any guidance.
Hi, I’d like to work on this as my first contribution to Node.js. Is this still available?
yes
Removing
good first issueas we received several PRs, and one of them has a few approvalsThis issue has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.
UTF8andUTF-8are also valid but not accepted by any existing utf8 fast paths (#48658, #49884)