Repository navigation
Docs imply that http globalAgent is created with keepAlive: false #48821
Description
Affected URL(s)
https://nodejs.org/api/http.html#new-agentoptions
Description of the problem
The docs state:
The default http.globalAgent that is used by http.request() has all of these values set to their respective defaults.
Whereas globalAgent is built with
module.exports = {
Agent,
globalAgent: new Agent({ keepAlive: true, scheduling: 'lifo', timeout: 5000 }),
};the only default there is scheduling: 'lifo'; keepAlive: true and timeout: 5000 are overrides.
(the history part of the globalAgent docs states "The agent now uses HTTP Keep-Alive by default." so that part is ok ✔️)
Activity
heysujal commentedon Jul 24, 2023
@VoltrexKeyva here is my understanding using
scheduling : 'lifo'is not an override but it's not actually required because it is setting the same value again.Also, I think we should add info only about the override for
keepAliveandtimeouthere https://nodejs.org/api/http.html#httpglobalagentSo, we can mention something like
"Global instance of Agent which is used as the default for all HTTP client requests with the following overrides"
keepAlive : truetimeout : 5000I would like to create a PR for this upon confirmation on above info.