You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
DNS lookupService fails with internal C error when given a string port number. #4837
The DNS module's lookupService method throws an unwrapped C error when given a string for a port number. This isn't ideal; preferably a TypeError would be thrown instead, or the function would just parse the string to an integer.
The following error messages is given for the failing test cases shown below.
Activity
evanlucas commentedon Jan 24, 2016
PR incoming to fix
dns: throw a TypeError in lookupService with invalid port
dns: throw a TypeError in lookupService with invalid port
dns: throw a TypeError in lookupService with invalid port
dns: throw a TypeError in lookupService with invalid port
dns: throw a TypeError in lookupService with invalid port
dns: throw a TypeError in lookupService with invalid port
dns: throw a TypeError in lookupService with invalid port