Repository navigation
readline.question #4833
Description
Activity
It's used by about 0.3% of modules, including babel, pm2, webdriverio, replace, atom-package-manager.
Yes, it's definitely used in quite a bit of code. Still, the inconsistency bugs me. I wonder if soft deprecation would work here if it's even something we're interested in.
I've used it and it is useful. It is a bit odd I suppose, but you would never catch an error there afaik. It simply doesn't make any sense to me why there would ever be one.
Well, even a method that doesn't raise errors (and whether or not
readlinecan/should do that is debateable) - it should have an(err, data)signature for consistency.I admit it's useful and I'm not for removing it.
Maybe put a big note in the docs saying it's inconsistenct with other node style APIs?
I wouldn't be against putting a note, but I don't think it should actually have an errback, since it would always be undefined.
Is there a synchronous substitute of
readline.question- added a commit that references this issue
on Jun 6, 2016 Good job closing this!
- added a commit that references this issue
on Jun 15, 2016 - added a commit that references this issue
on Jul 27, 2026
So, I found readline.question today, and it looks really odd.
First, it doesn't follow the
(err, data)nodeback convention at all (where do errors go?).Second, it doesn't really feel like something that should be in core.
Should it be soft-deprecated?
Should it be "fixed" to conform to the node-back convention (not very likely)?