You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Api docs scrolling and anchors appear broken #47858
The scrolling behaviour seems to be a bug in our JavaScript code behind the scrolling listening on the API docs JavaScript?
The anchor issue is a known issue on the all.html page, it's a tricky and complex bug and probably not worth to be fixed on the current tooling due to its complexity.
The issue about when clicking to an anchor being sent to the wrong place also seems to be an issue of the current HTML template and maybe JavaScript of the API docs.
Note that this issue is not an issue of the Website repository, neither for the Website Team. The related code is placed at nodejs/node.
@harshitphoenix feel free to work on them, but they might not be as easy as you think. The 2nd one for example is quite tricky.
It also seems that by removing these, the overall style gets broken the width of the content not respecting the window width. That should probably be fixed by using CSS grids. And allocating a fixed width of 250px for the first column and 1fr for the 2nd column.
Activity
harshitphoenix commentedon May 4, 2023
I will work on this one.
ovflowd commentedon May 4, 2023
all.htmlpage, it's a tricky and complex bug and probably not worth to be fixed on the current tooling due to its complexity.Note that this issue is not an issue of the Website repository, neither for the Website Team. The related code is placed at
nodejs/node.@harshitphoenix feel free to work on them, but they might not be as easy as you think. The 2nd one for example is quite tricky.
I'm moving this issue to https://github.com/nodejs/node repository as it should belong there.
ovflowd commentedon May 4, 2023
I've just found the culprit of the 1st bug, which seems to be related due the styling of
content-visiblityonsectiontags.I have no idea why we have these styles applied. But nevertheless, I'd be fine removing them.
ovflowd commentedon May 4, 2023
It also seems that by removing these, the overall style gets broken the width of the content not respecting the window width. That should probably be fixed by using CSS grids. And allocating a fixed width of 250px for the first column and 1fr for the 2nd column.
richardlau commentedon May 4, 2023
There's already a PR open for this: #41869
harshitphoenix commentedon May 4, 2023
Does the PR addresses both the issues?
ovflowd commentedon May 4, 2023
Nope.
mscdex commentedon May 4, 2023
There's an existing issue for this here. Unfortunately there hasn't been any movement on it AFAIK since then.
eri412 commentedon May 4, 2023
Yep, I initially looked through the issues in the wrong repo.
ovflowd commentedon May 5, 2023
I'm going to reply on the original issue some thoughts.