URL parser behaviour change in 18.16.0 #47555

Activity

1. nabinked

   changed the title [-]URL Parser behaviour change in 18.16.0[/-] [+]URL parser behaviour change in 18.16.0[/+] on Apr 14, 2023
2. KhafraDev

   added

   whatwg-urlIssues and PRs related to the WHATWG URL implementation.Issues and PRs related to the WHATWG URL implementation.

   on Apr 14, 2023
3. KhafraDev commented on Apr 14, 2023

   

   KhafraDev

   on Apr 14, 2023

   Member

   More actions

   cc @nodejs/url
4. Trott commented on Apr 14, 2023

   

   Trott

   on Apr 14, 2023

   Last edited by Trott

   Member

   More actions

   I'm able to reproduce this:

   ➜  ~ node
   Welcome to Node.js v18.16.0.
   Type ".help" for more information.
   > new URL('HTTP://AMAZON.COM').href
   'http://amaZon.com/'
   > 

   Node.js 18.16.0 uses Ada for parsing while 18.15.0 does not, so I strongly suspect this is either a bug in Ada or a bug in Node.js that was introduced as part of the change set to include Ada.

   @anonrig @lemire

   👍React with 👍2Reacted by Tobias Nießen and Yagiz Nizipli
5. MoLow

   added

   confirmed-bugIssues and PRs for confirmed bugs.Issues and PRs for confirmed bugs.

   on Apr 14, 2023
6. Trott commented on Apr 14, 2023

   

   Trott

   on Apr 14, 2023

   Member

   More actions

   Node.js 19.7.0 and newer has this same issue. 19.6.1 does not. And again, 19.7.0 is the version where Ada is introduced.
7. Trott

   added

   v18.x

   v19.x

   on Apr 14, 2023
8. anonrig commented on Apr 14, 2023

   

   anonrig

   on Apr 14, 2023

   Member

   More actions

   I will fix this in Ada. Thanks for reporting.

   👍React with 👍2Reacted by Moshe Atlow and Debadree Chatterjee
9. lemire commented on Apr 14, 2023

   

   lemire

   on Apr 14, 2023

   Member

   More actions

   That's odd.
10. lemire commented on Apr 14, 2023

    

    lemire

    on Apr 14, 2023

    Member

    More actions

    Wow.
11. anonrig

    assigned

    anonrig

    and

    lemire

    on Apr 14, 2023
12. anonrig commented on Apr 14, 2023

    

    anonrig

    on Apr 14, 2023

    Member

    More actions

    @lemire's pull request fixed this in Ada. We'll release a new version.
13. anonrig commented on Apr 17, 2023

    

    anonrig

    on Apr 17, 2023

    Member

    More actions

    Ada v2.1.0 will fix this issue.

    🎉React with 🎉1Reacted by Owen Buckley
14. nodejs-github-bot

    closed this as completedin #47598on Apr 19, 2023