Changed the riscv64 compilation path to the wrong one #46154

Activity

1. F3n67u

   added

   buildIssues and PRs related to Node.js builds or CI infrastructure.Issues and PRs related to Node.js builds or CI infrastructure.

   on Jan 11, 2023
2. F3n67u commented on Jan 11, 2023

   

   F3n67u

   on Jan 11, 2023

   Contributor

   More actions

   @targos Seems that we should also add "don't land on v18.x" label to #45149 because in v18.x branch src/heap/base/asm/riscv64 has not renamed to riscv yet. See https://github.com/nodejs/node/tree/v18.x/deps/v8/src/heap/base/asm.
3. targos commented on Jan 11, 2023

   

   targos

   on Jan 11, 2023

   Member

   More actions

   It's too late. The commit is already on v18.x. That's why this issue was opened.

   👍React with 👍1Reacted by Feng Yu
4. luyahan

   closed this as completedon Jan 17, 2023