Unqualified call to std::move in node_http2.cc

Warning (from clang-cl on Windows) that I don't know how to fix:

src\node_http2.cc(647,32): warning : unqualified call to 'std::move' [-Wunqualified-std-cast-call] [D:\Git\nodejs\node\libnode.vcxproj]

node/src/node_http2.cc

Lines 647 to 650 in 4bee69a

    
           env()->SetImmediate([entry = move(entry)](Environment* env) { 
        
             if (HasHttp2Observer(env)) 
        
               entry->Notify(env); 
        
           });

Just write as entry = std::move(entry)? Or doesn't that fix it?

src: use qualified `std::move` call in node_http2

Probably, thanks. #45555

src: use qualified `std::move` call in node_http2

Navigation Menu

Unqualified call to `std::move` in node_http2.cc #45543

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	env()->SetImmediate([entry = move(entry)](Environment* env) {
	if (HasHttp2Observer(env))
	entry->Notify(env);
	});

Unqualified call to std::move in node_http2.cc #45543

Description

Activity

bnoordhuis commented on Nov 20, 2022

targos commented on Nov 21, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Unqualified call to `std::move` in node_http2.cc #45543