Repository navigation
MD5 symbols missing from Windows library #45445
Description
Version
v18.12.1
Platform
Microsoft Windows NT 10.0.22000.0 x64
Subsystem
No response
What steps will reproduce the bug?
- Run
node-gyp rebuildon Windows
md5.c:
#include <openssl/md5.h>
void hash(void)
{
MD5_CTX c;
MD5_Init(&c);
MD5_Update(&c, NULL, 0);
MD5_Final(NULL, &c);
}binding.gyp:
{ 'targets': [{ 'target_name': 'md5', 'sources': ['md5.c'] }] }How often does it reproduce? Is there a required condition?
Always
What is the expected behavior?
Builds successfully as it does on other platforms (and Node.js 16 on Windows).
What do you see instead?
md5.obj : error LNK2001: unresolved external symbol MD5_Update [C:\Users\User\Development\md5\build\md5.vcxproj]
md5.obj : error LNK2001: unresolved external symbol MD5_Final [C:\Users\User\Development\md5\build\md5.vcxproj]
md5.obj : error LNK2001: unresolved external symbol MD5_Init [C:\Users\User\Development\md5\build\md5.vcxproj]
Additional information
No response
Activity
bnoordhuis commentedon Nov 13, 2022
That's because the
MD5_*()family of functions has been deprecated in openssl 3.0.That could be fixed by adding
DEPRECATEDIN_3_0to mkssldef_flags in node.gyp but that also enables a ton of other deprecated stuff (edit: over 1,000 extra symbols.)It's probably better to use the EVP interface,
EVP_md5().mohd-akram commentedon Nov 13, 2022
The code that's using it is not mine, it's in a library. Looking at it another way, that's 1,000+ incompatibilities between Node.js on Windows and other platforms :D, and compiling on Windows is already painful.
bnoordhuis commentedon Nov 13, 2022
You're welcome to open a pull request and see how it's received. libopenssl.a is exported with
-Wl,--whole-archiveon linux so it's reasonable to do something similar on windows.