FormData, Response, Request, and Headers have incorrect property descriptors

Version

v18.11.0

Platform

Microsoft Windows NT 10.0.19043.0 x64

Subsystem

No response

What steps will reproduce the bug?

The property descriptors should match such that this test succeeds:

for (const global of [
  'Headers',
  'Request',
  'Response',
  'FormData'
]) {
  const desc = Object.getOwnPropertyDescriptor(globalThis, global)
  
  assert.notStrictEqual(desc, undefined)
  assert.deepStrictEqual(desc.value, globalThis[global])
  assert.ok(desc.writable)
  assert.ok(!desc.enumerable)
  assert.ok(desc.configurable)
}

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior?

the tests from above pass

What do you see instead?

the descriptors are inconsistent with other environments

Additional information

No response

If you submit that to WPT, then node will fix that next time we update.

If WPT already contains tests but we're not testing that particular submodule, then please see test/wpt/README.md for how to enable them.

The tests exist https://github.com/web-platform-tests/wpt/blob/master/fetch/api/idlharness.any.js

I will look into enabling these tests in node but I've never worked with node's WPT runner and idlharness tests are a little more involved than other tests. 👍

I think we already run idlharness tests for other features (for example URL) without issues.

Cool, I'll look into it once a new version of undici is released and is updated in node. Otherwise a few tests will fail that don't anymore.

We should probably make sure that Undici is snapshotted, so we can get rid of the lazy-loading without perf implications.

Hey Team.
I am a newbie dev starting out in OSS, I would like to take this issue up, can anyone help me navigate through and fix this.
Thanks

I don't think this issue is actionable. Other globals (Blob and File, if File is ever made a global...) were made getters as well in #45659.

Caveat: we have to make some of the globals lazily-loaded too

Navigation Menu

Repository navigation

FormData, Response, Request, and Headers have incorrect property descriptors #45099

Version

Platform

Subsystem

What steps will reproduce the bug?

How often does it reproduce? Is there a required condition?

What is the expected behavior?

What do you see instead?

Additional information

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

FormData, Response, Request, and Headers have incorrect property descriptors #45099

Description

Version

Platform

Subsystem

What steps will reproduce the bug?

How often does it reproduce? Is there a required condition?

What is the expected behavior?

What do you see instead?

Additional information

Activity

bnoordhuis commented on Oct 20, 2022

KhafraDev commented on Oct 20, 2022

targos commented on Oct 22, 2022

KhafraDev commented on Oct 22, 2022

aduh95 commented on Oct 24, 2022

techsavvyash commented on Feb 4, 2023

KhafraDev commented on Feb 4, 2023

LeonxLJX commented on Sep 1, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions