Skip to content

python tools/test.py -J --mode=release parallel/test-* #44330

Description

@ronag

python tools/test.py -J --mode=release parallel/test-* doesn't seem to work anymore?

node$ python tools/test.py -J --mode=release parallel/test-*
  File "tools/test.py", line 230
    print(f" failed {len([i for i in outputs if i.UnexpectedOutput()]) + 1} out of {self.measure_flakiness + 1}")

Activity

ronag commented on Aug 21, 2022

@ronag
MemberAuthor

MoLow commented on Aug 21, 2022

@MoLow
Member

I had to upgrade my python version for it to work properly.
What version are you using?

added
buildIssues and PRs related to Node.js builds or CI infrastructure.
testIssues and PRs related to Node.js core tests and test infrastructure.
toolsIssues and PRs related to the tools directory.
and removed
buildIssues and PRs related to Node.js builds or CI infrastructure.
on Aug 21, 2022

ronag commented on Aug 21, 2022

@ronag
MemberAuthor

2.7

MoLow commented on Aug 21, 2022

@MoLow
Member

I think #43954 made tools/test.py work only on python 3
@ronag can you confirm by running python3 tools/test.py -J --mode=release parallel/test-*?

MoLow commented on Aug 21, 2022

@MoLow
Member

NVM, I reproduced locally:

python2 --version
Python 2.7.18

python2 tools/test.py -J message
  File "tools/test.py", line 230
    print(f" failed {len([i for i in outputs if i.UnexpectedOutput()]) + 1} out of {self.measure_flakiness + 1}")
                                                                                                               ^
SyntaxError: invalid syntax

and

python --version
Python 3.9.13

python tools/test.py -J message
[00:07|% 100|+  66|-   0]: Done

MoLow commented on Aug 21, 2022

@MoLow
Member

CC @aduh95
I am not sure how important it is to support python 2

ronag commented on Aug 21, 2022

@ronag
MemberAuthor

Thanks! That fixed it.

Trott commented on Aug 21, 2022

@Trott
Member

I am not sure how important it is to support python 2

We dropped support for Python 2 some time ago. It has been EOL for a while. @nodejs/python might have more context to supply (especially @cclauss).

cclauss commented on Aug 21, 2022

@cclauss
Contributor

Python 2 died 963 days ago on 1/1/2020. No security updates since then -- It should no longer be trusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    testIssues and PRs related to Node.js core tests and test infrastructure.toolsIssues and PRs related to the tools directory.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions