Automate timezone updates #43134

Activity

1. srl295 commented on Feb 10, 2022

   

   srl295

   on Feb 10, 2022

   Member

   More actions

   if you need help with the icu side in CI lmk
2. BethGriggs commented on May 5, 2022

   

   BethGriggs

   on May 5, 2022

   Member

   More actions

   Curious if we should consider moving this to nodejs/node (and potentially tagging with good first issue?). The automation would be on that repository, and this issue would probably get more visibility there.

   👍React with 👍6Reacted by Richard Lau, Michaël Zasso, Steven R. Loomis, Myles Borins, Rosalia Guerrero Arellano and Somesh Debnath
3. BethGriggs

   added

   release-agendaIssues and PRs to discuss during Release team meetings.Issues and PRs to discuss during Release team meetings.

   on May 5, 2022
4. srl295 commented on May 5, 2022

   

   srl295

   on May 5, 2022

   Member

   More actions

   @BethGriggs probably a good idea.
5. BethGriggs

   removed

   release-agendaIssues and PRs to discuss during Release team meetings.Issues and PRs to discuss during Release team meetings.

   on May 17, 2022
6. BethGriggs

   transferred this issue fromnodejs/Releaseon May 17, 2022
7. BethGriggs

   added

   good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.

   help wantedIssues that need assistance from volunteers or PRs that need help to proceed.Issues that need assistance from volunteers or PRs that need help to proceed.

   on May 17, 2022
8. srl295 commented on May 17, 2022

   

   srl295

   on May 17, 2022

   Member

   More actions

   ^ my offer stands

   👍React with 👍1Reacted by Beth Griggs
9. Ayushi15-Vamne commented on May 23, 2022

   

   Ayushi15-Vamne

   on May 23, 2022

   More actions

   Hey @MylesBorins,
   Can you please brief little more where that issue replicating.
   Thanks
10. MylesBorins commented on May 23, 2022

    

    MylesBorins

    on May 23, 2022

    ContributorAuthor

    More actions

    we embed icu in Node.js which has timezone information embedded. This timezone data can end up being updated separately from the icu dependency being updated, this is especially important for LTS versions of Node.js which may not get ICU updates regularly. It is important that the timezone data is up to date or it can cause programming erorrs or issues with services.

    This issue referenced in the original post does a good job of explaining how things can go bad.
11. jimezesinachi commented on Jul 7, 2022

    

    jimezesinachi

    on Jul 7, 2022

    More actions

    I'm interested in solving this issue. Where do I sign up?

    🎉React with 🎉4Reacted by Moshe Atlow, Marçal Simião, Olaegbe Abdul-Rahmon and Shivang Bhatnagar
12. bnoordhuis commented on Jul 8, 2022

    

    bnoordhuis

    on Jul 8, 2022

    Member

    More actions

    @rapaktech Right here. :-)

    Node's tzdata comes from ICU. ICU's binary data file is stored in deps/icu-small/source/data/in. Somehow that file should be updated to include newer tzdata - maybe by updating ICU's data/zone/* files from icu4c-71_1-data.zip and building a new .dat file?
13. srl295 commented on Jul 8, 2022

    

    srl295

    on Jul 8, 2022 via email

    Member

    More actions

    ICU has a whole guide on this topic, https://unicode-org.github.io/icu/userguide/datetime/timezone/#updating-the-time-zone-data And I thought node has a guide as well?
14. jimezesinachi commented on Jul 8, 2022

    

    jimezesinachi

    on Jul 8, 2022

    More actions

    Thanks @bnoordhuis & @srl295. Gone through the resources you shared, and I think I understand what to do.

    This is my first time contributing here and I'm not sure what the contributing guideline is. Would appreciate any pointers. Thanks.

    👍React with 👍2Reacted by Steven R. Loomis and Marçal Simião
15. 22 remaining items

    Load more

16. srl295 commented on Sep 15, 2022

    

    srl295

    on Sep 15, 2022

    Member

    More actions

    @mudassir-jmi @Shub3am hi. Take a look at #43988 that is where the latest work is

    👍React with 👍1Reacted by Shubham
17. aduh95

    closed this as completedin #43988on Sep 15, 2022
18. aduh95

    added a commit that references this issue on Sep 15, 2022

    tools: add timezone update workflow

    ...

    85b46e1
19. RafaelGSS

    added 3 commits that reference this issue on Sep 26, 2022

    tools: add timezone update workflow

    ...

    2e77644

    tools: add timezone update workflow

    ...

    0df181a
20. guangwong

    added 2 commits that reference this issue on Jan 3, 2023

    tools: add timezone update workflow

    ...

    6a96b0e

    tools: add timezone update workflow

    ...

    3467ef3