Repository navigation
performance.getEntriesBy[Name|Type](undefined) returns all the entries #42028
Description
Version
v16.13.2、v17.5.0
Platform
Linux meixg-desktop 5.11.0-43-generic #47~20.04.2-Ubuntu SMP Mon Dec 13 11:06:56 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Subsystem
perf_hooks
What steps will reproduce the bug?
performance.mark(undefined);
performance.mark('a');
const entries = performance.getEntriesByName(undefined);
console.log(entries);How often does it reproduce? Is there a required condition?
consistently
What is the expected behavior?
[
PerformanceMark {
name: 'undefined',
entryType: 'mark',
startTime: 74.92072999477386,
duration: 0,
detail: null
}
]
What do you see instead?
[
PerformanceMark {
name: 'undefined',
entryType: 'mark',
startTime: 74.92072999477386,
duration: 0,
detail: null
},
PerformanceMark {
name: 'a',
entryType: 'mark',
startTime: 75.06349003314972,
duration: 0,
detail: null
}
]
Additional information
Chrome、Safari will only output the 'undefined' one:
[PerformanceMark]
To retrieve all entries, we need to use .getEntries().
Activity
meixg commentedon Feb 17, 2022
Also,
.getEntriesByType(undefined)works different too.benjamingr commentedon Feb 18, 2022
@meixg is this something you would be interesting in contributing a fix for?
meixg commentedon Feb 18, 2022
Sure, leave it to me.
benjamingr commentedon Feb 23, 2022
@meixg working on this?
[-]performance.getEntriesByType(undefined) returns all the entries[/-][+]`performance.getEntriesBy[Name|Type](undefined)` returns all the entries[/+][-]`performance.getEntriesBy[Name|Type](undefined)` returns all the entries[/-][+]`performance.getEntriesByName(undefined)` returns all the entries[/+][-]`performance.getEntriesByName(undefined)` returns all the entries[/-][+]`performance.getEntriesBy[Name|Type[(undefined)` returns all the entries[/+][-]`performance.getEntriesBy[Name|Type[(undefined)` returns all the entries[/-][+]`performance.getEntriesBy[Name|Type](undefined)` returns all the entries[/+]meixg commentedon Feb 24, 2022
Yeah, just had a few busy days, made a PR for this :).
perf_hooks: do not return all entries with getEntriesBy[Name|Type]
benjamingr commentedon Feb 26, 2022
Thanks @meixg keep it up!
perf_hooks: do not return all entries with getEntriesBy[Name|Type]
perf_hooks: do not return all entries with getEntriesBy[Name|Type]
perf_hooks: do not return all entries with getEntriesBy[Name|Type]
perf_hooks: do not return all entries with getEntriesBy[Name|Type]