Skip to content

Fetch should not be installed if no_browser_globals==true #41816

Description

@targos

See

node/src/node.cc

Lines 366 to 373 in 7904331

if (!no_browser_globals()) {
result = ExecuteBootstrapper(
this, "internal/bootstrap/browser", &node_params, &node_args);
if (result.IsEmpty()) {
return MaybeLocal<Value>();
}
}

I could not add fetch to bootstrap/browser.js because it's not allowed to access CLI flags from this file.

Activity

  1. added
    fetchIssues and PRs related to the Fetch API.
    on Feb 1, 2022
  2. RaisinTen commented on Feb 13, 2022

    @RaisinTen
    Member

    PR: #41958

  3. RaisinTen commented on Feb 14, 2022

    @RaisinTen
    Member

    Labeling this as blocked, as there's probably no way to add fetch to the bootstrap script and honor the CLI option at the same time. We should probably just wait for fetch to become stable to be able to add it to bootstrap/browser.js. Feel free to remove the label if anyone thinks otherwise.

  4. added
    blockedPRs that are blocked by other issues or PRs.
    on Feb 14, 2022
  5. removed
    blockedPRs that are blocked by other issues or PRs.
    on Feb 14, 2022
  6. targos commented on Feb 14, 2022

    @targos
    MemberAuthor

    as there's probably no way to add fetch to the bootstrap script and honor the CLI option at the same time

    I agree with that, but there's probably a way to expose no_browser_globals() to JS and add it to the condition that installs fetch.

  7. RaisinTen commented on Feb 14, 2022

    @RaisinTen
    Member

    Ah, then #41969 should be okay, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    fetchIssues and PRs related to the Fetch API.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions