Skip to content

fixing incorrect 4.4.4.4 DNS reference(s) in examples #41803

Description

Affected URL(s)

https://nodejs.org/api/dns.html#dnspromisesreverseip

Description of the problem

fixing incorrect 4.4.4.4 DNS reference(s) in various examples,
to (what I assume) should be 8.8.8.8/8.8.4.4/dns.google (Google DNS 1 2 3).

note

not sure what the source of this mistake is
(I think it was an old Verizon name server),
but I see this a lot and not just in n00b codes,
but in big a$$ companies as well..

in most cases running the code in the example will just render a timeout (and a puzzled developer),
in other cases (silent fallback..) it may go through the os default name resolving chain which will render some unexpected results and be somewhat challenging to debug.. :|


edit:

IP address ranges that are designated for use in documentation 1
I would prefer a working example.

edit:

  1. https://github.com/features/code-search/signup
  2. https://cs.github.com/?scopeName=All+repos&scope=&q=repo%3Anodejs%2Fnode+%224.4.4.4%22

Activity

  1. ghost added
    docIssues and PRs related to Node.js documentation.
    on Feb 1, 2022
  2. maruf061 commented on Feb 1, 2022

    @maruf061

    Thanks for sharing

  3. added
    dnsIssues and PRs related to the dns subsystem.
    on Feb 1, 2022
  4. tniessen commented on Feb 1, 2022

    @tniessen
    Member

    It is indeed strange that the IPv6 address seems to point to Google but the IPv4 does not. On the other hand, these are just meant as an example and we don't want to push users toward using any specific company's DNS provider. (Putting my Cloudflare hat on: 1.1.1.1 is faster than 8.8.8.8.) There are IP address ranges that are designated for use in documentation that we could use.

    in most cases running the code in the example will just render a timeout (and a puzzled developer)

    Users should only call setServers if they have a good reason not to use the system's DNS resolver settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    dnsIssues and PRs related to the dns subsystem.docIssues and PRs related to Node.js documentation.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions