Repository navigation
Clarify where pull requests should go #407
Description
Given the large overlap of codebase between Node.js and io.js, it is often not easy for contributors to understand where to send patches. For instance, the two pull requests below express the exact same changes in the different projects:
- Improve performance of event and timer interfaces node-v0.x-archive#9007
- Improve performance of event and timer interfaces #406
What is the proper procedure?
Only create one pull request (where?) and hope it eventually gets merged in both?
Or create to pull requests like I have just done?
Maybe it would be good to clarify this in the contributors guidelines.
Activity
mikeal commentedon Jan 14, 2015
Send all patches here :)
ryanseys commentedon Jan 14, 2015
I think this is up to the contributor. Of course @mikeal wants you to land it here! 😉
RubenVerborgh commentedon Jan 14, 2015
But what's best for the ecosystem? Submitting it to both then?
bnoordhuis commentedon Jan 14, 2015
If it lands in joyent/node and it's noteworthy / useful enough, we'll eventually cherry-pick it into io.js. joyent/node is not known for high speed patch reviews, however; that's one of the reasons io.js exists.