Skip to content

Compiler warning while building OpenSSL 3 on macOS #40421

Closed
Closed
Compiler warning while building OpenSSL 3 on macOS#40421
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.macosIssues and PRs related to the macOS platform.opensslIssues and PRs related to the OpenSSL dependency.

Description

@targos
targos
opened on Oct 12, 2021
[132/3702] CC obj/deps/openssl/config/archs/darwin64-arm64-cc/asm_avx2/crypto/sha/openssl.sha1-armv8.o
<built-in>:416:9: warning: 'OPENSSLDIR' macro redefined [-Wmacro-redefined]
#define OPENSSLDIR "/System/Library/OpenSSL/"
        ^
<built-in>:415:9: note: previous definition is here
#define OPENSSLDIR "/Users/targos/git/nodejs/node/$|CONFIGURATION_NAME/obj/deps/openssl"
        ^
1 warning generated.

This is printed many times.

Activity

  1. targos
    added
    buildIssues and PRs related to Node.js builds or CI infrastructure.
    opensslIssues and PRs related to the OpenSSL dependency.
    on Oct 12, 2021
  2. iam-frankqiu
    added
    macosIssues and PRs related to the macOS platform.
    on Oct 12, 2021

  3. targos commented on Oct 12, 2021

    @targos
    targos
    on Oct 12, 2021
    MemberAuthor

    @nodejs/crypto @danbev

  4. targos commented on Oct 12, 2021

    @targos
    targos
    on Oct 12, 2021
    MemberAuthor

    BTW, $|CONFIGURATION_NAME looks wrong?

  5. mscdex commented on Oct 12, 2021

    @mscdex
    mscdex
    on Oct 12, 2021
    Contributor

    Looks like $|CONFIGURATION_NAME comes from gyp's ninja generator.

  6. mscdex commented on Oct 13, 2021

    @mscdex
    mscdex
    on Oct 13, 2021
    Contributor

    Seems to be happening on the OSX CI machines as well, but since make is used there we get:

    20:46:03 In file included from <built-in>:363:
20:46:03 <command line>:36:9: warning: 'OPENSSLDIR' macro redefined [-Wmacro-redefined]
20:46:03 #define OPENSSLDIR "/System/Library/OpenSSL/"
20:46:03         ^
20:46:03 <command line>:35:9: note: previous definition is here
20:46:03 #define OPENSSLDIR "/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1015/out/$(BUILDTYPE)/obj.target/deps/openssl"
20:46:03         ^
20:46:03 1 warning generated.

  7. danbev commented on May 9, 2022

    @danbev
    danbev
    on May 9, 2022
    Contributor

    I think this was fixed in cf7801d

    I've taken a look at a recent CI build and I can't see the warning:

    cc -o /Users/iojs/build/workspace/node-test-commit-osx-arm/nodes/osx11/out/Release/obj.target/openssl/deps/openssl/config/archs/darwin64-arm64-cc/asm_avx2/crypto/sha/sha1-armv8.o ../deps/openssl/config/archs/darwin64-arm64-cc/asm_avx2/crypto/sha/sha1-armv8.S '-DV8_DEPRECATION_WARNINGS' '-DV8_IMMINENT_DEPRECATION_WARNINGS' '-D_GLIBCXX_USE_CXX11_ABI=1' '-DNODE_OPENSSL_HAS_QUIC' '-D_DARWIN_USE_64_BIT_INODE=1' '-DOPENSSL_NO_PINSHARED' '-DOPENSSL_THREADS' '-DOPENSSL_NO_HW' '-DOPENSSL_API_COMPAT=0x10100001L' '-DSTATIC_LEGACY' '-DNDEBUG' '-DL_ENDIAN' '-DOPENSSL_BUILDING_OPENSSL' '-DECP_NISTZ256_ASM' '-DKECCAK1600_ASM' '-DOPENSSL_BN_ASM_MONT' '-DOPENSSL_CPUID_OBJ' '-DPOLY1305_ASM' '-DSHA1_ASM' '-DSHA256_ASM' '-DSHA512_ASM' '-DVPAES_ASM' '-DOPENSSL_PIC' '-DMODULESDIR="/Users/iojs/build/workspace/node-test-commit-osx-arm/nodes/osx11/out/Release/obj.target/deps/openssl/lib/openssl-modules"' '-DOPENSSLDIR="/Users/iojs/build/workspace/node-test-commit-osx-arm/nodes/osx11/out/Release/obj.target/deps/openssl"' '-DENGINESDIR="/dev/null"' -I../deps/openssl/openssl -I../deps/openssl/openssl/include -I../deps/openssl/openssl/crypto -I../deps/openssl/openssl/crypto/include -I../deps/openssl/openssl/crypto/modes -I../deps/openssl/openssl/crypto/ec/curve448 -I../deps/openssl/openssl/crypto/ec/curve448/arch_32 -I../deps/openssl/openssl/providers/common/include -I../deps/openssl/openssl/providers/implementations/include -I../deps/openssl/config -I../deps/openssl/config/archs/darwin64-arm64-cc/asm_avx2 -I../deps/openssl/config/archs/darwin64-arm64-cc/asm_avx2/include -I../deps/openssl/config/archs/darwin64-arm64-cc/asm_avx2/crypto -I../deps/openssl/config/archs/darwin64-arm64-cc/asm_avx2/crypto/include/internal -I../deps/openssl/config/archs/darwin64-arm64-cc/asm_avx2/providers/common/include  -O3 -gdwarf-2 -mmacosx-version-min=10.15 -arch arm64 -Wall -Wendif-labels -W -Wno-unused-parameter -Wno-missing-field-initializers -fno-strict-aliasing -MMD -MF /Users/iojs/build/workspace/node-test-commit-osx-arm/nodes/osx11/out/Release/.deps//Users/iojs/build/workspace/node-test-commit-osx-arm/nodes/osx11/out/Release/obj.target/openssl/deps/openssl/config/archs/darwin64-arm64-cc/asm_avx2/crypto/sha/sha1-armv8.o.d.raw   -c

    I'm going to close this issue but if anyone is still seeing this issue please re-open and I'll take a look.

  8. danbev
    closed this as completedon May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildIssues and PRs related to Node.js builds or CI infrastructure.macosIssues and PRs related to the macOS platform.opensslIssues and PRs related to the OpenSSL dependency.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions