Skip to content

V8 (9.5) has split the v8.h header #39876

Description

@targos

See v8/v8@ec06bb6

It shouldn't directly impact the Node.js build because v8.h is still here and includes everything it had before, but at least https://github.com/nodejs/node/blob/master/tools/install.py will have to be changed.

Activity

  1. added
    v8 engineIssues and PRs related to the V8 dependency.
    on Aug 25, 2021
  2. targos commented on Aug 25, 2021

    @targos
    MemberAuthor

    @nodejs/v8 is there something else that we need to care about? Should we keep using v8.h or try to move to the new smaller headers?

  3. verwaest commented on Aug 25, 2021

    @verwaest
    Contributor

    You can keep using v8.h but using smaller headers can be much more efficient. While I don't expect much churn, if you wait a bit before switching over you might avoid having to update includes a few times over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    v8 engineIssues and PRs related to the V8 dependency.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions