Skip to content

Uncovered parent path checks in module.js #3849

Closed

Description

@tejasmanohar

this code needs unit test as identified here #3844 (comment)

Activity

  1. tejasmanohar commented on Nov 16, 2015

    @tejasmanohar
    Author

    @thefourtheye looking thru the tests setup now. any idea ~ where the test for this would go? is there a getting started guide for developing w/ node? slightly lost

  2. thefourtheye commented on Nov 16, 2015

    @thefourtheye
    Contributor

    The module module's tests are in these files

    ➜  io.js git:(master) ✗ ls test/parallel/test-module-*
    test/parallel/test-module-globalpaths-nodepath.js
    test/parallel/test-module-loading-error.js
    test/parallel/test-module-nodemodulepaths.js
    ➜  io.js git:(master) ✗ ls test/sequential/test-module-*          
    test/sequential/test-module-loading.js
    
    

    As the name indicates, tests under sequential directory will be run one after the other. This section in CONTRIBUTING.md has few information which might help you

  3. tejasmanohar commented on Nov 16, 2015

    @tejasmanohar
    Author

    Aha, wish those were split up into directories like test/sequential/module/loading.js or similar :) ... anyways, I do want to add these tests to get some more experience working around here... will do tmrw (CST)

  4. thefourtheye commented on Nov 16, 2015

    @thefourtheye
    Contributor

    @tejasmanohar Cool, feel free to ask your questions in IRC if you prefer chat like assistance :-) Night night.

  5. added
    moduleIssues and PRs related to the module subsystem.
    on Nov 16, 2015
  6. bnoordhuis commented on Feb 12, 2016

    @bnoordhuis
    Member

    Closing due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    moduleIssues and PRs related to the module subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions