fs: add support for async iterators to fs.writeFile #38075

Activity

1. yagipy

   changed the title [-]fs: writeFile support AsyncIterable, Iterable & Stream as data argument (regular fs version)[/-] [+]fs: add support for async iterators to `fs.writeFile`[/+] on Apr 4, 2021
2. aduh95 commented on Apr 4, 2021

   

   aduh95

   on Apr 4, 2021

   Contributor

   More actions

   If #37948 lands, I think we shouldn't add features to the callback API.
   And even if it doesn't land, I would advice to focus on other part of the codebase that needs improvement: users who want to use async iterators with a callback API can use util.callbackify. That being said, I wouldn't block if a PR was sent with an implementation, I just don't think it's necessary.

   👍React with 👍4Reacted by linkgoron, Darshan Sen, Hiroyuki Yagihashi and Théo LUDWIG
3. aduh95

   added

   fsIssues and PRs related to file-system APIs and the fs module.Issues and PRs related to file-system APIs and the fs module.

   questionIssues asking questions about Node.js.Issues asking questions about Node.js.

   on Apr 4, 2021
4. benjamingr commented on Apr 4, 2021

   

   benjamingr

   on Apr 4, 2021

   Member

   More actions

   I would be +1 and would be happy to help you collaborate on this regardless of the callback APIs status of legacy yes/no.

   It would probably make sense for consistency IMO.

   👍React with 👍1Reacted by Hiroyuki Yagihashi
5. jimmywarting commented on Apr 13, 2021

   

   jimmywarting

   on Apr 13, 2021

   More actions

   if the async iterator is able to write plain uint8array instead of relying on the buffer, then yes +1
6. benjamingr commented on Apr 13, 2021

   

   benjamingr

   on Apr 13, 2021

   Member

   More actions

   @jimmywarting are there any FS APIs that require Buffers and don't take "regular" Uint8Arrays?
7. jimmywarting commented on Apr 13, 2021

   

   jimmywarting

   on Apr 13, 2021

   Last edited by jimmywarting

   More actions

   @benjamingr Hmm, maybe in the old days, things might have changed for the better now :)

   remember that i could write a uint8array cuz it wasn't a buffer - this seems to no longer be the case
8. github-actions commented on Jun 27, 2026

   

   github-actionsbot

   on Jun 27, 2026 – with GitHub Actions

   Contributor

   More actions

   This issue has been marked as stale due to 210 days of inactivity.
   It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.
9. github-actions

   added

   staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.Issues and PRs marked stale due to inactivity and scheduled for automatic closure.

   on Jun 27, 2026
10. github-actions commented on Jul 28, 2026

    

    github-actionsbot

    on Jul 28, 2026 – with GitHub Actions

    Contributor

    More actions

    This issue has been automatically closed after 30 days of inactivity following its stale status (no activity for a total of 120 days).
    If this is still relevant, feel free to reopen it or leave a comment with additional details so we can continue the discussion.
11. github-actions

    closed this as not plannedon Jul 28, 2026