Skip to content

investigate flaky sequential/test-fs-watch #36247

Closed
#36249
Closed
investigate flaky sequential/test-fs-watch#36247
#36249
Labels
flaky-testIssues and PRs involving tests that fail intermittently in CI.fsIssues and PRs related to file-system APIs and the fs module.macosIssues and PRs related to the macOS platform.

Description

@Trott
Trott
opened on Nov 24, 2020
  • Test: sequential/test-fs-watch
  • Platform: osx1015
  • Console Output:
01:28:10 not ok 3107 sequential/test-fs-watch
01:28:10   ---
01:28:10   duration_ms: 120.86
01:28:10   severity: fail
01:28:10   exitcode: -15
01:28:10   stack: |-
01:28:10     timeout
01:28:10   ...

test-orka-macos10.15-x64-2

Activity

  1. Trott
    added
    fsIssues and PRs related to file-system APIs and the fs module.
    macosIssues and PRs related to the macOS platform.
    flaky-testIssues and PRs involving tests that fail intermittently in CI.
    on Nov 24, 2020

  2. Trott commented on Nov 24, 2020

    @Trott
    Trott
    on Nov 24, 2020
    MemberAuthor

    Stress test: https://ci.nodejs.org/job/node-stress-single-test/205/

  3. Trott commented on Nov 24, 2020

    @Trott
    Trott
    on Nov 24, 2020
    MemberAuthor

    I'm pretty sure this is the old "macos returns the watcher before it's actually watching the file system" issue. My solution in the past has been to have the file modified every few seconds in the test instead of just once.

  4. Trott commented on Nov 24, 2020

    @Trott
    Trott
    on Nov 24, 2020
    MemberAuthor

    Stress test: https://ci.nodejs.org/job/node-stress-single-test/205/

    Failed 2 times in 1000 runs on osx15. I'm able to replicate this locally. It failed 4 times in 1000 runs.

  5. Trott
    added a commit that references this issue on Nov 27, 2020

    test: fix flaky sequential/test-fs-watch

    8ba65b5
  6. Trott
    closed this as completedin 8ba65b5on Nov 27, 2020
  7. danielleadams
    added a commit that references this issue on Dec 7, 2020

    test: fix flaky sequential/test-fs-watch

    2c7358e
  8. targos
    added a commit that references this issue on May 1, 2021

    test: fix flaky sequential/test-fs-watch

    b11e3ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    flaky-testIssues and PRs involving tests that fail intermittently in CI.fsIssues and PRs related to file-system APIs and the fs module.macosIssues and PRs related to the macOS platform.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions