Repository navigation
Keeping up with landing things and reviews #35826
Description
Hey,
A lot of changes regarding how to land things happened since I joined Node. With the commit queue, NCU, criteria changes, team pings and other things. Some collaborators (like Ruben) helped me in the past when I wanted to keep up, it was always 1x1.
I have a feeling (not sure if it's well founded) that the number of people reviewing things is rather small and the number of people landing things is significantly smaller.
I think it would be useful for the TSC or just a collaborator that feels like it to do a session (similar to the original collaborator onboarding) that surveys the (updated) protocols for collaborators namely:
- Landing things technical know how ("you don't need to apply a patch anymore, just add this label - if that doesn't work here is node core utils etc").
- Automation (what changed, GitHub actions linting etc).
- Reviewing things, teams team pings and how to better help with reviews.
- Behaviour in the repo (responding to non-collaborators in PRs, expected conduct, how to best ask for moderation).
If something like this is already happening - feel free to point me there.
As a collaborator, I often have periods (of a month or a few at a time) of zero to no activity and then bursts of activity. I am not as engaged as most of the TSC (I'm hoping that's the case :]) so it's a lot harder to keep up.
This is just something I came up with when I noticed a long-time useful contributor stumble with this and had a "If it's happening to them and it's happening to me, it's probably happening to others".
Of course, I would totally understand if no one picks it up - I am asking for "free work" - it's just something I think would be useful
Activity
benjamingr commentedon Oct 27, 2020
I'll ping @nodejs/tsc in case the TSC wants to pick this up.
(I'm not pinging nodejs/collaborators since that feels like a much too broad ping - but I'm not sure that's a correct call since I think feedback from other collaborators would be very useful)
mcollina commentedon Oct 27, 2020
+1 I think this would be great to do. Maybe @mmarchini? She worked on most of the new automation.
Trott commentedon Oct 27, 2020
Some stats for the last 6 months that are probably more interesting than useful:
1712 commits landed
Of the 104 accounts (including the bot) in the Collaborators group, 56 landed at least 1 commit in that time
full data table
Trott commentedon Oct 27, 2020
I would love to see that "56" be a bigger number, so I'm 👍 on doing this if it will help.
benjamingr commentedon Oct 27, 2020
@Trott those numbers show that more than half of all node commits landed in the last 6 months are you, @addaleax and @jasnell :]
Given we squash commits (usually) that difference is even larger.
Trott commentedon Oct 27, 2020
I guess we wouldn't even need to to create new material for this. We could just walk through the relevant parts of the onboarding.md doc.
mhdawson commentedon Oct 27, 2020
A session sounds great to encourage/make people more comfortable landing.
lucky-gru commentedon Oct 29, 2020
that's awesome
mmarchini commentedon Nov 2, 2020
A session sounds like a good idea. Do you think a blog post would also be helpful?
benjamingr commentedon Nov 2, 2020
@mmalecki sure, though the content I am referring to is specifically for collaborators - so the reach of such a blog post would be ±100 people and it would probably confuse the rest of the Node.js blog readers if that's where it'll be published.
mmarchini commentedon Nov 2, 2020
Would it make sense for us to have a collaborators blog? 😄
joyeecheung commentedon Nov 3, 2020
We could just start a new repo and use GitHub pages anyway :)
mmarchini commentedon Nov 3, 2020
Ohh that's a good idea :D
benjamingr commentedon Jan 25, 2022
This has stalled a while ago - so closing (with the usual "if anyone feels differently feel free to reopen").