Skip to content

test: async-hello-world/binding.cc is missing unistd.h in windows #3531

Closed
Closed
test: async-hello-world/binding.cc is missing unistd.h in windows#3531
Labels
c++Issues and PRs that require attention from people who are familiar with C++.testIssues and PRs related to Node.js core tests and test infrastructure.windowsIssues and PRs related to the Windows platform.

Description

@john-yan
john-yan
opened on Oct 26, 2015

async-hello-world/binding.cc is missing unistd.h in windows. Can we use std::this_thread::sleep_for as an alternative?

Activity

  1. Trott
    added
    testIssues and PRs related to Node.js core tests and test infrastructure.
    on Oct 26, 2015
  2. mscdex
    added
    c++Issues and PRs that require attention from people who are familiar with C++.
    windowsIssues and PRs related to the Windows platform.
    on Oct 26, 2015

  3. bnoordhuis commented on Oct 28, 2015

    @bnoordhuis
    bnoordhuis
    on Oct 28, 2015
    Member

    Fixed by 4139f2a. Sorry, didn't see you linked to this issue in PR #3532.

  4. bnoordhuis
    closed this as completedon Oct 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    c++Issues and PRs that require attention from people who are familiar with C++.testIssues and PRs related to Node.js core tests and test infrastructure.windowsIssues and PRs related to the Windows platform.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions