Skip to content

createReadStream/createWithStream doesn't validate fd arg is valid #35178

Closed

Description

@ronag

Missing a validateInteger check

Activity

  1. added
    fsIssues and PRs related to file-system APIs and the fs module.
    good first issueIssues that are suitable for first-time contributors.
    on Sep 13, 2020
  2. ronag commented on Sep 13, 2020

    @ronag
    MemberAuthor

    Similar with path argument.

  3. dsuarezlogans commented on Oct 1, 2020

    @dsuarezlogans

    Hello I would like to help with this issue, but I don't completely understand what is required and where to do the work, can you please point me on the right direction please? 🙏

  4. abhinavjonnada82 commented on Oct 2, 2020

    @abhinavjonnada82

    Can I get this with some instructions, please?

  5. grayparser commented on Oct 2, 2020

    @grayparser

    @dsuarezlogans @abhinavjonnada82 There is already a pull request that could potentially close this issue.
    You can take a look at other good first issues for your first contribution to nodejs!

    If there is a pull request attached to the issue you are looking at, I would suggest looking at another one to not conflict with the developer who is already working on it.

    After finding the first issue you want to work on, you should read this document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    fsIssues and PRs related to file-system APIs and the fs module.good first issueIssues that are suitable for first-time contributors.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions