Repository navigation
CodeOwner looks like not working for wasi #35162
Description
Activity
cc @Trott
Not related to write permissions because we now have a custom bot to circumvent that.
Looking at the issue the team was mentioned for reviewing. Do you mean the team was not added as a reviewer? In that case it needs write permissions, but we settled on using the mention comment approach instead otherwise the org will become unmaintained if we have too many subteams on the collaborators team.
Looking at the issue the team was mentioned for reviewing. Do you mean the team was not added as a reviewer?
Yeap.
Also, related files not showing ownership. Below is a showcase for quic.
Right, as I said the decision was to not use GitHub's builtin codeowners feature because of how hard it makes GitHub org management. FWIW I'm -1 to adding wasi as a subteam of collaborators, and I think we should remove the teams that are today (quic, net, http2)
Reacted by Alex Yang and Rich TrottRight, as I said the decision was to not use GitHub's builtin codeowners feature because of how hard it makes GitHub org management. FWIW I'm -1 to adding wasi as a subteam of collaborators, and I think we should remove the teams that are today (quic, net, http2)
+1 to all of that. This is working as expected. We're doing the best we reasonably can within the limitations of the functionality of CODEOWNERS.
I will close it for now then.
@mmarchini CodeOwner looks like not working. Is this because wasi team should have write permission for
nodejs/node repo ?
Originally posted by @gengjiawen in #35104 (comment)