url.pathToFileURL doesn't generate valid URLs for UNC paths

Node.js version: v12.18.3 and v14.8.0
Platform: Windows 10 (10.0.19041)
Subsystem: url

What steps will reproduce the bug?

const url = require("url")
url.pathToFileURL("\\\\laptop\\My Documents\\FileSchemeURIs.doc")

Expected behavior

As per Microsoft's UNC URI documentation):

file://laptop/My%20Documents/FileSchemeURIs.doc

Actual behavior

URL {
  href: 'file:///laptop/My%20Documents/FileSchemeURIs.doc',
  origin: 'null',
  protocol: 'file:',
  username: '',
  password: '',
  host: '',
  hostname: '',
  port: '',
  pathname: '/laptop/My%20Documents/FileSchemeURIs.doc',
  search: '',
  searchParams: URLSearchParams {},
  hash: ''
}

hostname should be laptop (not '').
pathname should be /My%20Documents/FileSchemeURIs.doc (not be prefixed by /laptop/).

This sounds like a valid bug to me. The implementation is at https://github.com/nodejs/node/blob/master/lib/internal/url.js#L1368 where it seems clear this isn't properly being taken into account.

I'd be happy to swing at it, I haven't committed to node yet.

That would be really great, please feel free if you can. I believe that on posix machines such a path should be ignored, like for other path functions I believe. Building for Windows is documented at https://github.com/nodejs/node/blob/master/BUILDING.md#windows.

(interestingly enough, fileURLToPath already behaves correctly)

Do you want pathToFileURL to throw a new error code for invalid UNC paths (for example, when the path is missing like \\invalid?)

Shouldn't need a new error code. Using one like ERR_INVALID_ARG_VALUE should work for that.

I'm not sure what would be best - I don't think we currently do path validations, but if there is no adequate URL representation that would support fileURLToPath as its converse it likely makes sense to.

lib: add UNC support to url.pathToFileURL()

Navigation Menu

Repository navigation

url.pathToFileURL doesn't generate valid URLs for UNC paths #34736

What steps will reproduce the bug?

Expected behavior

Actual behavior

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

url.pathToFileURL doesn't generate valid URLs for UNC paths #34736

Description

What steps will reproduce the bug?

Expected behavior

Actual behavior

Activity

guybedford commented on Aug 11, 2020

mceachen commented on Aug 11, 2020

guybedford commented on Aug 11, 2020

mceachen commented on Aug 11, 2020

mceachen commented on Aug 11, 2020

jasnell commented on Aug 11, 2020

guybedford commented on Aug 11, 2020

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions