Assertion `parser->current_buffer_.IsEmpty()' Exception #34016

Activity

1. jasnell

   added

   httpIssues and PRs related to the http subsystem.Issues and PRs related to the http subsystem.

   http_parserIssues and PRs related to the HTTP parser implementation or http_parser binding.Issues and PRs related to the HTTP parser implementation or http_parser binding.

   on Jun 22, 2020
2. addaleax commented on Jun 22, 2020

   

   addaleax

   on Jun 22, 2020

   Member

   More actions

   Is there any chance you can verify that this also happens on the latest v12.x release? v12.0.0 was over a year ago, and lots of bug fixes have gone into it since then.
3. omkadiri commented on Jun 23, 2020

   

   omkadiri

   on Jun 23, 2020

   Author

   More actions

   I got the same exception running with version 12.18.1

   /.nvm/versions/node/v12.18.1/bin/node[3921]: ../src/node_http_parser_impl.h:509:static void node::{anonymous}::Parser::Finish(const v8::FunctionCallbackInfov8::Value&): Assertion `parser->current_buffer_.IsEmpty()' failed.
   1: 0xa08900 node::Abort() [/.nvm/versions/node/v12.18.1/bin/node]
   2: 0xa0897e [/.nvm/versions/node/v12.18.1/bin/node]
   3: 0xa20302 [/.nvm/versions/node/v12.18.1/bin/node]
   4: 0xbeaee9 [/.nvm/versions/node/v12.18.1/bin/node]
   5: 0xbeccd7 v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [/.nvm/versions/node/v12.18.1/bin/node]
   6: 0x13c9919 [/.nvm/versions/node/v12.18.1/bin/node]
4. bnoordhuis commented on Jul 6, 2020

   

   bnoordhuis

   on Jul 6, 2020

   Member

   More actions

   I haven't been able to reproduce but I can see the general shape of the bug. The call chain probably looks like this:

   • Parser::Execute() -> llhttp_execute() -> Parser::on_body() -> parserOnBody() -> ... -> parser.finish()

   I think it should be safe to remove the CHECK and reset the current_buffer_ fields like this:

   diff --git a/src/node_http_parser.cc b/src/node_http_parser.cc
   index c7a3df8d06..f9729f3f51 100644
   --- a/src/node_http_parser.cc
   +++ b/src/node_http_parser.cc
   @@ -514,7 +514,9 @@ class Parser : public AsyncWrap, public StreamListener {
        Parser* parser;
        ASSIGN_OR_RETURN_UNWRAP(&parser, args.Holder());
    
   -    CHECK(parser->current_buffer_.IsEmpty());
   +    parser->current_buffer_.Clear();
   +    parser->current_buffer_len_ = 0;
   +    parser->current_buffer_data_ = nullptr;
        Local<Value> ret = parser->Execute(nullptr, 0);
    
        if (!ret.IsEmpty())

   Opinions? Parser::Execute() performs the same reset after calling llhttp_execute().

   @omkadiri If you want you can compile Node from source with that patch applied until this issue is resolved.

   👍React with 👍3Reacted by omkadiri, Charles and Sergei Startsev
5. addaleax

   added a commit that references this issue on Jul 14, 2020

   test: add regression tests for HTTP parser crash

   ...

   18667ac
6. cjihrig

   added a commit that references this issue on Jul 23, 2020

   test: add regression tests for HTTP parser crash

   ...

   24df1c0
7. addaleax

   added 2 commits that reference this issue on Sep 22, 2020

   http: fix crash for sync write errors during header parsing

   ...

   756ac65

   test: add regression tests for HTTP parser crash

   ...

   867c451
8. santigimeno

   closed this as completedon Oct 22, 2020