Repository navigation
Console class ignores ignoreErrors on Node.js v14.3.0 #33628
Description
Activity
- changed the title
[-]Console class do not respect ignoreErrors on Node.js[/-][+]Console class do not respect ignoreErrors on Node.js v14.3.0[/+]on May 29, 2020 - changed the title
[-]Console class do not respect ignoreErrors on Node.js v14.3.0[/-][+]Console class ignores `ignoreErrors` on Node.js v14.3.0[/+]on May 29, 2020 It seems because of
ws = require('fs').createWriteStream('./foo.log'); ws.destroy(); ws.write('foo');
do not throw error any more.
So, errors thrown on Node.js v12 & v10 were bug, that was fixed somewhere on v13/v14 ?
But I think it's a breaking change.
But I think it's a breaking change.
Yes, it was labeled as semver-major.
So, errors thrown on Node.js v12 & v10 were bug, that was fixed somewhere on v13/v14 ?
Not sure exactly what you mean. A lot of things fall under that description. But this specific case wasn't a bug per se, but it was ambiguous/undefined behavior that we changed to make it predictable. There were also other problems this caused that the change resolved.
It was a very long discussion as you can notice from the PR and not at decision taken lightly.
Thanks for quick response 👍
I saw there was long disucssion in #29197, and the change seems reasonable to me.
My understanding is that the error I saw on Node.js v12 were due to ambiguous/undefined hehaviors.I am closing this issue as "as-designed" or similar.
What steps will reproduce the bug?
repro.jswhich contents is below:ndoe repro.jsHow often does it reproduce? Is there a required condition?
Every time it reproduces on the above environment with the above procedure.
What is the expected behavior?
Invoking
c.logshould throw error, since the underlying streams are already destroyed, like below:Note) The expected errors are thrown on Node.js v12.16.3 and v10.20.1.
What do you see instead?
No errors thrown, and script runs succesfully.
It seems that
Consoleclass ignoresignorErrorsoption.