REPL quits unexpectedly during tab completion

Reproduction:

Start the nodejs repl.
Start a function; enter "function() {" (without quotes) and hit [ENTER].
Type "arguments." (without quotes) and hit [TAB].

Expected:
Available properties on arguments object, varying depending on strict / non-strict mode.

Actual:
Exit to command prompt with exit code 0.

Screenshot:

~ $ nodejs
> function() {
... arguments.~ $ echo $?
0

Version:
NodeJS 4.1 on Linux 3.19

Looks like this bug has existed since v0.12.

Looks like problems started with c0721bc which introduced domains into the REPL error handling.

At the point where tab completion is requested, arguments is undefined because the function has not been invoked. Until the function is invoked, there's no way to know if arguments will contain a 0 property, a 10 property, or what.

Node v0.10.40 would do nothing when you hit tab to get properties on an undefined value.

Current Node throws a ReferenceError.

So I think the fix to this bug will/should throw a ReferenceError rather than display results.

PR #3358 is intended to fix this bug.

Fixed in #3358.

lib: avoid REPL exit on completion error

Nice, thanks! :-)

Impressive response time.

lib: avoid REPL exit on completion error

Navigation Menu

Repository navigation

REPL quits unexpectedly during tab completion #3346

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

REPL quits unexpectedly during tab completion #3346

Description

Activity

mscdex commented on Oct 13, 2015

Trott commented on Oct 13, 2015

Trott commented on Oct 13, 2015

Trott commented on Oct 14, 2015

Trott commented on Oct 21, 2015

usernameisalreadytaken2014 commented on Oct 26, 2015

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions