Skip to content

Test addons on windows test-ci #3339

Description

@Fishrock123

Looks like window's test-ci doesn't include addons, where makefile does.

Do we have any idea what would be necessary to run these on the windows CI? It seems fairly important.

Related: #2830

cc @nodejs/build

Activity

  1. added
    windowsIssues and PRs related to the Windows platform.
    buildIssues and PRs related to Node.js builds or CI infrastructure.
    on Oct 13, 2015
  2. bnoordhuis commented on Oct 13, 2015

    @bnoordhuis
    Member

    Also related: #2428.

    I'm not sure if batch file scripting is flexible enough to handle building add-ons, in particular ones scraped from the documentation. We'd probably either need to build them unconditionally or implement a poor man's make in JS or python.

    For the CI, it's fine to build them from scratch every time. It's kind of annoying when developing locally though.

  3. mathiask88 commented on Oct 20, 2015

    @mathiask88
    Contributor

    For the sake of completeness: #2537

  4. added
    duplicateIssues and PRs that are duplicates of other issues or PRs.
    on Oct 21, 2015
  5. Fishrock123 commented on Oct 21, 2015

    @Fishrock123
    ContributorAuthor

    @mathiask88 Ah good catch :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildIssues and PRs related to Node.js builds or CI infrastructure.duplicateIssues and PRs that are duplicates of other issues or PRs.windowsIssues and PRs related to the Windows platform.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions