Repository navigation
util.inspect shouldn’t format objects with the [[IsHTMLDDA]] internal slot as undefined #31889
Description
Activity
I suppose this would matter when using electron, since you could actually do
util.inspect(document.all). I can add an upstream Object::IsUndetectable and we could check it here.We could also hack this in as
typeof v === 'undefined' && v !== undefined.Reacted by ExE Boss and Anna HenningsenOne solution would be to add
util.types.isObject(target), which would perform:- If Type(target) is Object, then return true.
- Return false.
That would take care of that check, as C++ code doesn’t care whether an object is undetectable, since you can pass
document.allas thethisvalue to bothFunction.prototype.toString,Object.prototype.toStringandObject.prototype.valueOf.
A polyfilled version is:
function isObject(target) { if (target === null || target === undefied) return false; switch (typeof target) { case "object": case "function": return true; case "undefined": try { return Object.prototype.valueOf.call(target) === target; } catch {} } return false; }
- added a commit that references this issue
on Mar 10, 2020 - added a commit that references this issue
on Mar 30, 2020 - added a commit that references this issue
on Apr 22, 2020 - added a commit that references this issue
on Jul 27, 2026
utilWhat steps will reproduce the bug?
Run
node --allow-natives-syntax -p 'util.inspect(%GetUndetectable())'What is the expected behavior?
What do you see instead?
Additional information
This is because the type check in
util.inspectdoesn’t account for objects with the[[IsHTMLDDA]]internal slot:node/lib/internal/util/inspect.js
Lines 681 to 688 in cdac185