Skip to content

add debug logs to _stream_writable #31761

Description

@YoDaMa

Is your feature request related to a problem? Please describe.
In debugging some Node.js stream related code, I'm getting debug logs for the readable stream, but not seeing any for the writable. Upon further investigation I found that there are no debug logs set up in writable stream.

https://github.com/nodejs/node/blob/master/lib/_stream_writable.js

Describe the solution you'd like
Add some nice logging to _stream_writable similar to _stream_readable.

Activity

  1. changed the title [-]https://github.com/nodejs/node/blob/master/lib/_stream_writable.js[/-] [+]add debug logs to _stream_writable[/+] on Feb 13, 2020
  2. added
    feature requestIssues requesting new Node.js features.
    streamIssues and PRs related to Node.js streams.
    on Feb 13, 2020
  3. juanarbol commented on Feb 18, 2020

    @juanarbol
    Member

    I'll work on this one.

  4. juanarbol commented on Feb 21, 2020

    @juanarbol
    Member

    Any specific events you want to be covered?

  5. YoDaMa commented on Feb 21, 2020

    @YoDaMa
    Author

    @juanarbol I don't have specifics, except that'd I'd essentially like parity with the _stream_readable debug logs.

  6. juanarbol commented on Feb 24, 2020

    @juanarbol
    Member

    Get it, I'll put all the documented events, I may add some extras, as readable stream debug logs.

  7. YoDaMa commented on Feb 24, 2020

    @YoDaMa
    Author

    Thank you @juanarbol !

  8. juanarbol commented on Feb 25, 2020

    @juanarbol
    Member

    I've sent the first proposal:

    #31937

  9. github-actions commented on Mar 8, 2022

    @github-actions
    Contributor

    There has been no activity on this feature request for 5 months and it is unlikely to be implemented. It will be closed 6 months after the last non-automated comment.

    For more information on how the project manages feature requests, please consult the feature request management document.

  10. added
    staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.
    on Mar 8, 2022
  11. github-actions commented on Apr 8, 2022

    @github-actions
    Contributor

    There has been no activity on this feature request and it is being closed. If you feel closing this issue is not the right thing to do, please leave a comment.

    For more information on how the project manages feature requests, please consult the feature request management document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    feature requestIssues requesting new Node.js features.staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.streamIssues and PRs related to Node.js streams.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions