Skip to content

--enable-static produces thin archives on Linux #30335

Closed
Closed
--enable-static produces thin archives on Linux#30335
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.questionIssues asking questions about Node.js.

Description

@wan9chi
wan9chi
opened on Nov 8, 2019

This makes it inconvenient to distribute Node.js as a prebuilt static library for embedders.

Based on what I learned from #7957 (comment), thin archives save space and compilation time, and they are turned off if the build target is a static library and the OS is solaris.

Shouldn't the operator be or instead of and? From what I understand SmartOS can't handle thin archives so they should be disabled whatever the build target is.

Activity

  1. wan9chi commented on Nov 8, 2019

    @wan9chi
    wan9chi
    on Nov 8, 2019
    ContributorAuthor

    cc: @bnoordhuis

  2. bnoordhuis
    added
    buildIssues and PRs related to Node.js builds or CI infrastructure.
    on Nov 8, 2019

  3. bnoordhuis commented on Nov 8, 2019

    @bnoordhuis
    bnoordhuis
    on Nov 8, 2019
    Member

    standalone_static_library is only relevant when building a static archive. gyp raises an error when you try to enable it for a non-static library build, hence the and.

  4. bnoordhuis commented on Nov 12, 2019

    @bnoordhuis
    bnoordhuis
    on Nov 12, 2019
    Member

    I'm closing this as answered, cheers.

  5. bnoordhuis
    closed this as completedon Nov 12, 2019
  6. bnoordhuis
    added
    questionIssues asking questions about Node.js.
    on Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildIssues and PRs related to Node.js builds or CI infrastructure.questionIssues asking questions about Node.js.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions