Skip to content

Improve test/js-native-api/test_bigint/test.js #30185

Closed
Closed
Improve test/js-native-api/test_bigint/test.js#30185

Description

@mpark86
mpark86
opened on Oct 31, 2019

Replace assert.throws with common.expectsError in test/js-native-api/test_bigint/test.js.

Activity

  1. mpark86
    added a commit that references this issue on Oct 31, 2019

    test: replaced 'assert.throws' with 'common.expectsError' - Fix nodej…

    cfdf43b

  2. lundibundi commented on Nov 22, 2019

    @lundibundi
    lundibundi
    on Nov 22, 2019
    Member

    @mpark86 ping, did you perhaps forgot to open a PR?
    (Also, PTAL https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines for commit message guidelines)

  3. targos commented on Dec 26, 2020

    @targos
    targos
    on Dec 26, 2020
    Member

    I'm closing this because of the lack of response. Feel free to open a pull request directly if this is still relevant!

  4. targos
    closed this as completedon Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions