Skip to content

fs.watch should throw an exception if recursive is not supported #29901

Description

@exx8

It has been discussed in the past, that recursion watch is not implementable with good performances in Linux . And it is actually documented, But currently, the fs.watch just ignores this option without signalling the user that the recursive has been ignored. I truly believe that an exception should be thrown if recursive is ignored, as it might cause unexpected bugs while cross-platforming an app or a script, And probably most users wouldn't imagine that such incapability exists, and probably won't look it up.
Of course, this is a breaking change.

Activity

  1. sam-github commented on Oct 9, 2019

    @sam-github
    Contributor

    Seems reasonable to me.

  2. exx8 commented on Oct 9, 2019

    @exx8
    Author

    Okay, I believe I should wait for more approvals?
    Then I'll be more than happy for this to be my first contribution to the project.

  3. BridgeAR commented on Oct 9, 2019

    @BridgeAR
    Member

    @exx8 feel free to open a PR with the necessary changes. Such changes are rarely discussed in depth beforehand and the PR itself should be sufficient.

  4. added
    fsIssues and PRs related to file-system APIs and the fs module.
    on Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    fsIssues and PRs related to file-system APIs and the fs module.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions