bitfields? #29126

Activity

1. ronag commented on Aug 14, 2019

   

   ronag

   on Aug 14, 2019

   Last edited by ronag

   MemberAuthor

   More actions

   e.g. readable state

   from 23 (184 bytes?):

   objectMode
   highWaterMark
   buffer
   length
   pipes
   flowing
   ended
   endEmitted
   reading
   sync
   needReadable
   emittedReadable
   readableListening
   resumeScheduled
   paused
   emitClose
   autoDestroy
   destroyed
   defaultEncoding
   awaitDrain
   decoder
   encoding
   endEmitted

   to 9 (72 byttes? almost fits in cacheline):

   bitfield
   highWaterMark
   buffer
   length
   pipes
   defaultEncoding
   awaitDrain
   decoder
   encoding
2. addaleax commented on Aug 14, 2019

   

   addaleax

   on Aug 14, 2019

   Member

   More actions

   Is this something worth investigating?

   Yes. Would you be interested in opening a PR and seeing how the benchmarks go?

   👍React with 👍1Reacted by Robert Nagy
3. Fishrock123

   added

   lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.Issues and PRs involving general changes in the lib/ or src/ directories.

   on Aug 14, 2019
4. ronag commented on Aug 17, 2019

   

   ronag

   on Aug 17, 2019

   Last edited by ronag

   MemberAuthor

   More actions

   @addaleax: So from my research it seems the performance improvements are small (0-10%) and some cognitive overhead is involved. The only reason this might be worth looking into is to reduce memory usage (which can be relevant for e.g. http).

   Should we close this?
5. ronag

   closed this as completedon Sep 22, 2019
6. ronag

   reopened this on Dec 29, 2019
7. ronag

   closed this as completedon Dec 29, 2019