Repository navigation
REPL complete function swallows errors #28546
Description
@estrada9166 recently brought up that test/parallel/test-repl-save-load.js is not working as it should. It should fail as is it but the errors are swallowed due to calling complete.
It seems like the domain does not propagate the error properly and it's silently swallowed. Adding an error listener to the active domain in the complete function that throws the error fixes the problem but it causes some side effects in other cases. We should only add the listener to the domains that do not handle the error properly at the moment.
Ping @Trott since you fixed some of these cases before.
Activity
repl: fix autocomplete while using .load
BridgeAR commentedon Jul 10, 2019
It turned out that the test file swallowed the errors, not the complete function. There where multiple bugs in the test itself and also two small issues in the REPL's
.saveand.loadfunction that are fixed by #28608.test: make repl tests more resilient
repl: fix autocomplete while using .load
test: make repl tests more resilient
repl: fix autocomplete while using .load
Please ignore this msg (#1)