Skip to content

node -p process.verions display issue on Windows Cmd #27819

Closed
Closed
node -p process.verions display issue on Windows Cmd#27819
Labels
confirmed-bugIssues and PRs for confirmed bugs.consoleIssues and PRs related to the console subsystem.windowsIssues and PRs related to the Windows platform.

Description

@nanixne
nanixne
opened on May 22, 2019

{
node: �[32m'12.3.0'�[39m,
v8: �[32m'7.4.288.27-node.17'�[39m,
uv: �[32m'1.28.0'�[39m,
zlib: �[32m'1.2.11'�[39m,
brotli: �[32m'1.0.7'�[39m,
ares: �[32m'1.15.0'�[39m,
modules: �[32m'72'�[39m,
nghttp2: �[32m'1.38.0'�[39m,
napi: �[32m'4'�[39m,
llhttp: �[32m'1.1.3'�[39m,
http_parser: �[32m'2.8.0'�[39m,
openssl: �[32m'1.1.1b'�[39m,
cldr: �[32m'35.1'�[39m,
icu: �[32m'64.2'�[39m,
tz: �[32m'2019a'�[39m,
unicode: �[32m'12.1'�[39m
}

Activity

  1. vsemozhetbyt commented on May 22, 2019

    @vsemozhetbyt
    vsemozhetbyt
    on May 22, 2019
    Contributor

    Can reproduce for v12.3.0 on Windows 7 x64 with cmd.exe. Output in the REPL is OK.

  2. ZYSzys
    added
    windowsIssues and PRs related to the Windows platform.
    on May 22, 2019

  3. richardlau commented on May 22, 2019

    @richardlau
    richardlau
    on May 22, 2019
    Member

    12.2.0 also fails but 12.1.0 is okay.

    {
  node: �[32m'12.2.0'�[39m,
  v8: �[32m'7.4.288.21-node.17'�[39m,
  uv: �[32m'1.28.0'�[39m,
  zlib: �[32m'1.2.11'�[39m,
  brotli: �[32m'1.0.7'�[39m,
  ares: �[32m'1.15.0'�[39m,
  modules: �[32m'72'�[39m,
  nghttp2: �[32m'1.38.0'�[39m,
  napi: �[32m'4'�[39m,
  llhttp: �[32m'1.1.3'�[39m,
  http_parser: �[32m'2.8.0'�[39m,
  openssl: �[32m'1.1.1b'�[39m,
  cldr: �[32m'35.1'�[39m,
  icu: �[32m'64.2'�[39m,
  tz: �[32m'2019a'�[39m,
  unicode: �[32m'12.1'�[39m
}

    {
  node: '12.1.0',
  v8: '7.4.288.21-node.16',
  uv: '1.28.0',
  zlib: '1.2.11',
  brotli: '1.0.7',
  ares: '1.15.0',
  modules: '72',
  nghttp2: '1.38.0',
  napi: '4',
  llhttp: '1.1.1',
  http_parser: '2.8.0',
  openssl: '1.1.1b',
  cldr: '35.1',
  icu: '64.2',
  tz: '2019a',
  unicode: '12.1'
}

  4. BridgeAR commented on May 22, 2019

    @BridgeAR
    BridgeAR
    on May 22, 2019
    Member

    I had a look at the changelog and I can't find anything obvious. Could someone verify that c2a03d58c3 has no impact? It seems the only entry that might have caused this? Otherwise it's probably best to bisected the commit.

  5. richardlau commented on May 22, 2019

    @richardlau
    richardlau
    on May 22, 2019
    Member

    Latest nightly from master also fails:

    {
  node: �[32m'13.0.0-nightly2019052247c5c3da86'�[39m,
  v8: �[32m'7.4.288.27-node.17'�[39m,
  uv: �[32m'1.29.1'�[39m,
  zlib: �[32m'1.2.11'�[39m,
  brotli: �[32m'1.0.7'�[39m,
  ares: �[32m'1.15.0'�[39m,
  modules: �[32m'72'�[39m,
  nghttp2: �[32m'1.38.0'�[39m,
  napi: �[32m'4'�[39m,
  llhttp: �[32m'1.1.3'�[39m,
  http_parser: �[32m'2.8.0'�[39m,
  openssl: �[32m'1.1.1b'�[39m,
  cldr: �[32m'35.1'�[39m,
  icu: �[32m'64.2'�[39m,
  tz: �[32m'2019a'�[39m,
  unicode: �[32m'12.1'�[39m
}

  6. richardlau commented on May 22, 2019

    @richardlau
    richardlau
    on May 22, 2019
    Member

    Reverting 2b24ffa on master restores the expected behaviour. I'll open a revert PR.

  7. richardlau
    added a commit that references this issue on May 22, 2019

    Revert "lib: print to stdout/stderr directly instead of using console"

    7d192a3

  8. richardlau commented on May 22, 2019

    @richardlau
    richardlau
    on May 22, 2019
    Member

    PR: #27823

  9. Fishrock123 commented on May 22, 2019

    @Fishrock123
    Fishrock123
    on May 22, 2019
    Contributor

    Can someone check if process._rawDebug(message) has the same effect in Windows CMD?

  10. Fishrock123
    added
    consoleIssues and PRs related to the console subsystem.
    on May 22, 2019

  11. joyeecheung commented on May 22, 2019

    @joyeecheung
    joyeecheung
    on May 22, 2019
    Member

    Do you actually see colors in the original version of node -p?

  12. targos commented on May 22, 2019

    @targos
    targos
    on May 22, 2019
    Member

    yes:
    image

  13. joyeecheung commented on May 22, 2019

    @joyeecheung
    joyeecheung
    on May 22, 2019
    Member

    @targos

    Thanks. It seems we have to use uv_write for TTY on Windows so that libuv converts the color codes for us. I won't be near a Windows machine anytime soon, so I guess we could leave the patch reverted for now (or unless someone is willing to pick it up).

  14. bzoz commented on May 22, 2019

    @bzoz
    bzoz
    on May 22, 2019
    Contributor

    we have to use uv_write for TTY on Windows so that libuv converts the color codes for us

    That is exactly what is happening, ANSI codes are emulated on Windows with WinApi calls.

  15. richardlau
    added
    confirmed-bugIssues and PRs for confirmed bugs.
    on May 22, 2019
  16. richardlau
    added a commit that references this issue on May 22, 2019

    lib: use console.log for TTY on Windows

    c7dabf0

  17. richardlau commented on May 22, 2019

    @richardlau
    richardlau
    on May 22, 2019
    Member

    @targos

    Thanks. It seems we have to use uv_write for TTY on Windows so that libuv converts the color codes for us. I won't be near a Windows machine anytime soon, so I guess we could leave the patch reverted for now (or unless someone is willing to pick it up).

    I've submitted an alternative to the full revert that falls back to console.log() for TTY on Windows: #27829

  18. addaleax
    closed this as completedin 1a96abeon May 26, 2019
  19. targos
    added a commit that references this issue on May 28, 2019

    Revert "lib: print to stdout/stderr directly instead of using console"

    9b90385
  20. sjarmak
    added a commit that references this issue on Jul 27, 2026

    Revert "lib: print to stdout/stderr directly instead of using console"

    1a96abe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    confirmed-bugIssues and PRs for confirmed bugs.consoleIssues and PRs related to the console subsystem.windowsIssues and PRs related to the Windows platform.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions