API docs: type for TLS Certificate's subjectaltname field is wrong. #27721

Activity

1. bnoordhuis

   added

   docIssues and PRs related to Node.js documentation.Issues and PRs related to Node.js documentation.

   good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.

   tlsIssues and PRs related to the tls subsystem.Issues and PRs related to the tls subsystem.

   on May 16, 2019
2. danbeglin commented on May 16, 2019

   

   danbeglin

   on May 16, 2019

   Last edited by danbeglin

   Contributor

   More actions

   I'll put a PR in this evening to fix this.

   I'll double check that TlsSocket.getPeerCertificate() does return a string as @cakoose says, and update the docs accordingly

   👍React with 👍1Reacted by Sam Roberts
3. cakoose commented on May 16, 2019

   

   cakoose

   on May 16, 2019

   Author

   More actions

   Steps you can use to check getPeerCertificate():

   get-peer-certificate.js

   const https = require('https');
   https.get('https://httpbin.org/get', res => {
       console.log('getPeerCertificate', res.socket.getPeerCertificate());
   });
   

   $ node get-peer-certificate.js
   ...
     subjectaltname: 'DNS:httpbin.org, DNS:*.httpbin.org',
   ...
   
4. facebook-github-bot

   added a commit that references this issue on May 16, 2019

   [PR] lib/node: Add type definition for TLS certificate objects.

   ...

   56353ff
5. danbeglin

   added a commit that references this issue on May 17, 2019

   doc: corrected tlsSocket.getPeerCertificate response type

   ...

   004baf8
6. danbev

   closed this as completedin 0ca9297on May 21, 2019
7. BridgeAR

   added a commit that references this issue on May 21, 2019

   doc: corrected tlsSocket.getPeerCertificate response type

   ...

   9f5b690
8. sjarmak

   added a commit that references this issue on Jul 27, 2026

   doc: corrected tlsSocket.getPeerCertificate response type

   ...

   0ca9297